[#20420] - [4.0] CODEOWNERS support
- Closed
- 16 May 2018
- Medium
- Build: staging
- # 20420
As discussed with @wilsonge at JAB it would be good to implement github codeowners support for J4. It does support the ability to request reviews from different people or teams for each branch within the same .git folder
joomla-cms-bot
- | Labels |
Added:
?
|
||
guess you didnt read what i wrote :(
No I did, but for everyone else who needs to understand more about this the context is all explained much better in that thread. The discussion in that thread is important, and would just happen again in this issue - linking the two stops having to fight the same battled over and over again.
Basically you are saying implement it for Joomla 4 - whereas the other thread has already implemented it for Joomla 3. The concept and discussion points are mainly still valid
Remember - not everyone is as close to the project as you, some people need context.
The CODEOWNERS file was merged up, so we do have that in place now on the 4.0 branch.
It needs to be expanded upon as I was trying to argue for in the original PR so that proper teams are set up across the repo. Especially as a fair number of resources are moving around.
I cherry-picked this in jab on Saturday as we discussed. Unless you want to have different code owners for this there’s nothing more to be done here
My reading was that you did it all in one file in the main branch and not
in each branch.
And yes there are different folders and possibly owners to monitor in the
j4 branch
On Wed, 16 May 2018, 00:44 George Wilson, notifications@github.com wrote:
I cherry-picked this in jab on Saturday as we discussed. Unless you want
to have different code owners for this there’s nothing more to be done here—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#20420 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8bsdkzJXTVQn3thwEuxgpG2YimIRks5ty2hxgaJpZM4UAXsQ
.
It works per branch. It kicked in on the 4.0 PRs as soon as that merged up.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-16 00:33:23 |
| Closed_By | ⇒ | brianteeman |
Well Repo Owner / Org Owner can merge even without a review but it got appended:
I'm happy to fix the errors just let me know which ;)
Just because they can doesnt mean they should ;)
I will put it on my todo list for after paris to review. Some are simple like missing . at the end of sentences but there are other parts that dont read well
Thanks
#20137