? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
13 May 2018

Hello everyone,

with the Google Summer of Code 2017 project, we implemented a new workflow extension in Joomla! 4, which replaces the current publish/unpublish/trashed/archived state. We want to implement a flexible and unlimited workflow which can be extended for other extensions, too.

Presentation at the JWC 2017: https://www.youtube.com/watch?v=5e-HECq44B0
Presentation at JAB 2018: https://youtu.be/z-TfSEggUZM

Additional Information

https://docs.joomla.org/Publishing_Workflow
https://docs.joomla.org/GSOC_2017_Project_Ideas#Project_VI:_Publishing_Workflow_in_Joomla.21

Testing Instructions

Install the PR via the Patchtester and reinstall your Joomla! or download the ZIP file (https://github.com/bembelimen/joomla-cms/archive/publishing-workflow.zip) and make a fresh installation. Afterwards go to the Article manager, there you'll find a new menu entry "Workflows", play with it around. You can also use the implemented default workflow.

Workflows will be assigned in the category parameters.

Images

grafik

grafik

grafik

Comments, tips, support would be very appreciated!

avatar bembelimen bembelimen - open - 13 May 2018
avatar bembelimen bembelimen - change - 13 May 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 May 2018
Category Administration com_categories com_content com_menus com_messages
avatar bembelimen bembelimen - change - 13 May 2018
The description was changed
avatar bembelimen bembelimen - edited - 13 May 2018
avatar brianteeman
brianteeman - comment - 13 May 2018

I will do a PR against your branch next week to make the language files correct english.

Can you please change the qn to quotename etc

avatar bembelimen bembelimen - change - 13 May 2018
Labels Added: ?
avatar bembelimen bembelimen - change - 13 May 2018
The description was changed
avatar bembelimen bembelimen - edited - 13 May 2018
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2018
Category Administration com_categories com_content com_menus com_messages SQL Administration com_admin com_categories com_content com_menus com_messages
avatar carlitorweb
carlitorweb - comment - 22 May 2018

@bembelimen can you fix the conflict files here, for test it?

avatar brianteeman
brianteeman - comment - 24 May 2018

I tried to test this and on apply the database changes I got

"1101 BLOB, TEXT, GEOMETRY or JSON column 'description' can't have a default value"

avatar brianteeman
brianteeman - comment - 24 May 2018

Having two columns with states (states and 0) is confusing and probably not needed

chrome_2018-05-24_09-01-43

I would remove the second one (0) and at the same time give the transitions column a name and not just an icon

avatar brianteeman
brianteeman - comment - 24 May 2018

The workflows, transitions and states should have "Names" not "Titles"

COM_WORKFLOW_TITLE="Title"
==>
COM_WORKFLOW_TITLE="Name"

avatar brianteeman
brianteeman - comment - 24 May 2018

On a new item there is no visible state - this is confusing and unexpected. For me a new article should have a state displayed and this should be the default for that user

chrome_2018-05-24_09-10-32

chrome_2018-05-24_09-07-55

avatar brianteeman
brianteeman - comment - 24 May 2018

It is confusing that sometimes you write State and sometimes you wrote Status

avatar brianteeman
brianteeman - comment - 24 May 2018

I dont find using the state icon to open the select list to be intuitive. Maybe its just me. Maybe it should either not display the text until the select is displayed OR it should always display the select. A better UX than me can advise ;)

toggle

avatar brianteeman
brianteeman - comment - 1 Jul 2018

Has this been abandoned?

avatar bembelimen
bembelimen - comment - 1 Jul 2018

No? There will be some updates this months.

avatar brianteeman
brianteeman - comment - 26 Jul 2018

It would be great if the merge conflicts could be resolved so that we can test the latest changes

avatar bembelimen
bembelimen - comment - 26 Jul 2018

We're working on it. We have to rebuild the implementation of com_content

avatar bembelimen
bembelimen - comment - 8 Aug 2018

@brianteeman we have here two different things with the same wording:

  1. The "Status" which representate the status of the current viewed item (like a banner is published, a workflow itself is unpublished etc.)
  2. The "States" which are the new "layer" in the workflow, where you define your workflow states

I would like to have the 2nd one completly renamed into something "unique" which don't leads to confusion ("All states have a status" e.g.)

Is there any good English term which describes the functionality of "States" without confusion with "Status"?

avatar brianteeman
brianteeman - comment - 8 Aug 2018

I agree 100% with your observation about the similarity and confusion of using status and states although they are technically the correct terms

I will take a look at what others do in this case

avatar brianteeman
brianteeman - comment - 8 Aug 2018

I am still getting my head around it but

The "States" which are the new "layer" in the workflow, where you define your workflow states

Could that be stages?
eg
Stage 1 create content
Stage 2 review content
Stage 3 Publish content

avatar wilsonge
wilsonge - comment - 8 Aug 2018

I'm going to merge this to push this forward as there are issues keeping this in sync. There's clearly several issues still to work out but people can create PRs as they go

avatar wilsonge wilsonge - close - 8 Aug 2018
avatar wilsonge wilsonge - merge - 8 Aug 2018
avatar wilsonge wilsonge - change - 8 Aug 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-08 21:31:02
Closed_By wilsonge
avatar brianteeman
brianteeman - comment - 8 Aug 2018

For the record I dont agree with this being merged in its current state and would like to see it reverted and instead of being on a personal repo moved to a joomla-projects repo like all the others and then issues can be worked on there.

This is nowhere near mergeable

avatar infograf768
infograf768 - comment - 9 Aug 2018

This PR has totally broken a new clean 4.0 installation when trying to create articles.
500 'v40_multi.wa.state_id' isn't in GROUP BY

0 Argument 1 passed to Joomla\Utilities\ArrayHelpergetColumn() must be of the type array, boolean given, called in /Applications/MAMP/htdocs/installmulti/joomla40/administrator/components/com_content/Model/ArticlesModel.php on line 483
avatar alikon
alikon - comment - 9 Aug 2018
  • no postgresql
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Aug 2018
avatar infograf768
infograf768 - comment - 9 Aug 2018

@franz-wohlkoenig

As I have done a fully clean install from 4.0-dev, the new tables exist here.
Issue is in code.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Aug 2018

a nightly didn't work so a clean Install is better?

avatar infograf768
infograf768 - comment - 9 Aug 2018

My issue above is when using multilang.
Creating an issue now

avatar infograf768
infograf768 - comment - 9 Aug 2018

See #21475

avatar brianteeman
brianteeman - comment - 9 Aug 2018

Sorry but this is way beyond not ready it is not correct #21476

avatar laoneo
laoneo - comment - 9 Aug 2018

Please open new issues or pull requests regarding the new workflow feature. This pr got merged and all comments will likely get forgotten.

avatar alikon
alikon - comment - 9 Aug 2018

ok will do, but ......

avatar brianteeman
brianteeman - comment - 11 Aug 2018

Please open new issues or pull requests regarding the new workflow feature. This pr got merged and all comments will likely get forgotten.

Add a Comment

Login with GitHub to post a comment