[#20353] - Deprecate ContactModelContact::getContactQuery()
- Fixed in Code Base
- 28 May 2018
- Medium
- Build: staging
- # 20353
- Diff
- Quy:patch-1
User tests: Successful: Unsuccessful:
Redo Issue #16460.
Summary of Changes
Deprecate ContactModelContact::getContactQuery() instead of removing.
This removes the method ContactModelContact::getContactQuery(). I was unable to find any place in our codebase where we use it and to be honest, it looks as if this was added 8 years ago rather by mistake. All changes since then seem to have been mass-refactorings. While the method does return more or less correct data, it does not return all data that you get with ContactModelContact::getItem(). Since the method is protected and in a component, there should be no issue with backwards compatibility.
Thanks @Hackwar
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20353.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20353.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-28 14:56:32 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on 697f5f7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20353.