User tests: Successful: Unsuccessful:
Pull Request for Issue #20049 .
Change users toolbar buttons visibility
/administrator/index.php?option=com_users&view=users
Delete
- Select State -
to Enabled
:Block
;Unblock
- Select State -
to Disabled
:Unblock
Delete
;Block
- Select Active State -
to Activated
:Activate
The buttons will be displayed depending on the filter
All buttons are always displayed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_users |
Labels |
Added:
?
|
I have tested this item
I am not in favor of this patch because the Filters will not display on smartphones (vertical), therefore the Delete button would never display
@infograf768 Hmm. And the truth. Just now noticed.
At the same time I looked. in com_content. There, too, do not display the delete button, because the Filters will not display
I am not in favor of this patch because the Filters will not display on smartphones (vertical), therefore the Delete button would never display
I don't think this is the case. As there is no filter on mobile, the delete button will always be displayed. All buttons are displayed if no filter is set.
I don't think this is the case. As there is no filter on mobile, the delete button will always be displayed. All buttons are displayed if no filter is set.
@infograf768 rights. In this PR I specifically made that the delete button is displayed only if the filter is set. The application is the same as in com_content only instead of trashed
and usedblocked
However, if it's only a delete button, I have one idea.
I can remove from this PR the change of the display of the Delete
button to make it visible always.
And after the adoption of this PR. Make a new one. And add a full option.
Delete only blocked users
If someone needs this function, he can turn it on in the settings. If not. By default, it will be disabled.
Besides. If so to do. That it will be more than just hiding the button, namely a full function, which will not allow you to remove a non-blocked user.
@ciar4n
I've checked it also.
I don't think this is the case. As there is no filter on mobile, the delete button will always be displayed. All buttons are displayed if no filter is set.
That's not true. There is no Delete button without changing the Status
filter to Trashed
. Only a button to change the status of entries to Trashed
. But no way to delete them afterwards.
As @Septdir said
At the same time I looked. in com_content. There, too, do not display the delete button, because the Filters will not display
And that's the case in all core components where Trashed status exists.
However, if it's only a delete button, I have one idea. ...
I would prefer a consistent solution for whole Joomla instead of additional configuration options or individual solutions that must be explained.
"Make deletion of items also on mobile devices possible". I've never understood why the Search Tools are hidden below 768px. They don't look nice but they are useful.
It has never been the intended behaviour that you can do everything on mobile. This is very common on applications and can be seen here on github
This is very common on applications and can be seen here on github
Maybe. From my point of view that's a ""bug"" ;-) in modern times but can be solved by a not perfect CSS override.
But I still think concerning com_users:
I would prefer a consistent solution ... instead of additional configuration options or individual solutions that must be explained.
But I didn't want to block programmer's creativity. Just an input.
Maybe it's better close this PR and create new for Joomla 4?
If everyone agrees, then decide how to be with the Delete
button(in this PR) and how will the time I do PR for J4
I am going to close this and it can be re-evaluated for J4. The concept of progressive display of toolbar buttons that you describe has always been rejected, sadly.
The concept of the toolbar has been changed for J4 so it might not even be needed
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-21 16:28:35 |
Closed_By | ⇒ | brianteeman |
@brianteeman No problems. As I wrote above, I do not have a clear position on this issue and I have a plugin for this.
Hmm. I can also make a plugin for removing only blocked users.
In advance I will say I do not have a competitive position on this PR.
If on any of my sites requires administration or moderation of users. I install the plugin. Which hides all unnecessary actions except. And prints only in the filter.
Like that.
New
Edit
Batch
- Select State -
=Enabled
also showsBlock
- Select State -
=Disabled
also showsUnblock
Delete
-Select Active State -
=Unactivated
also showsActivate
And in this PR with a clean filter, all buttons are displayed except
Delete
, so the checks were harder.In my opinion. If the
Delete
button is displayed only for blocked users. This will reduce the number of erroneous deletions.So if you think that this innovation is not required, PR can be immediately closed. If there are constructive proposals, I am ready to listen to them and, if possible,