[#20322] - Enable Profiling tab for mysql (PDO) queries and disable cache in debug mode
- Fixed in Code Base
- 17 Nov 2018
- Medium
- Build: staging
- # 20322
- Diff
- csthomas:query-cache
User tests: Successful: Unsuccessful:
Pull Request for Issue #13265.
Summary of Changes
- This PR makes the query cache disabled when db driver runs in debug mode.
- Enable Profile for Mysql PDO.
Not direct forked but based on #13268.
Testing Instructions
Details at #13268
- Enable debug mode in global config and system debug plugin
- Test at least one of driver: Mysql, MySqli or PDO Mysql.
- Check debug console "Database Queries" and "Profile" tab. Each query should run without using database cache.
Expected result
No cached query.
On PDOMYSQL driver profile tab is enabled.
Actual result
On debug mode queries use database cache.
On PDOMYSQL driver profile tab is disabled.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Title |
|
||||||
At now it may be hard to follow the test instruction because the cache is disabled by default in mysql 5.7.
You will only see the difference in PDOMYSQL driver, in which the Profile tab will be visible.
To enable the cache, you can add the following lines to the mysql configuration file.
In case of Ubuntu 18 is /etc/mysql/mysql.conf.d/mysqld.cnf
query_cache_type = 1
query_cache_size = 10M
query_cache_limit = 10M
This PR is designed to display more relevant information when the debug mode is enabled.
Maybe there is one more person to test any driver and do simple code review on the rest.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20322.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20322.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20322.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-17 17:33:14 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 8b23be5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20322.