Feeling Lucky
?
?
[#20306] - [4.0] Various installation cleanups
- Fixed in Code Base
- 6 May 2018
- Medium
- Build: 4.0-dev
- # 20306
- Diff
- wilsonge:fix/cleanup-installation
User tests: Successful: Unsuccessful:
- Cleans up how options are passed around the models
- Fixes database check (which was stored in the pre-installed CMS session and therefore
db_createdproperty isn't found - Makes
deleteInstallationFolderpublic - Fix fatal error when sample data cannot be found
Testing:
- Check installer still works
- Sample data can now be installed in the installer
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
| Labels |
Added:
?
|
||
| Title |
|
||||||
franz-wohlkoenig
- comment
- 6 May 2018
changed Title to make clear its about 4.0.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20306.
| Category | Installation | ⇒ | Installation Language & Strings |
wilsonge
- comment
- 6 May 2018
Then let's get a PR in for deleting it after this is merged. This is fixing at least 3 other issues as I've documented above - so it's not a reason to reject the PR
| Labels |
Added:
?
|
||
mbabker
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-06 23:40:15 |
| Closed_By | ⇒ | mbabker |
infograf768
- comment
- 7 May 2018
Understand the limitations of this PR:
Reminder though
- We still do not have the UI to delete older tables when installing on same db
- Installing one of the possible languages gets in a loop although language is installed
@wilsonge You should not fix that, you should remove it. Because we should get rid of the samledata SQL files. That was the whole point of the module?