[#20293] - Revert #19977: Plugins field behavior
- Fixed in Code Base
- 14 May 2019
- Medium
- Build: staging
- # 20293
- Diff
- SharkyKZ:Plugins_field_1
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
PR #19977 wasn't tested properly. As a result, it introduced unwanted behavior when saving form. The change prevents default value from being saved when it is set as a custom option in XML form.
Additionally, it adds check for a hardcoded language constant. This is not correct because the constant is added through custom option in XML form and could be anything.
Testing Instructions
Enable a Captcha plugin (e.g. reCaptcha).
Select the plugin as default Captcha plugin in Global Configuration and save.
Disable the plugin.
Go to Global Configuration and save again.
a) Open username reminder or password reset page
b) Check Captcha setting value (either in configuration.php or through JFactory::getApplication()->get('captcha')).
Expected result
a) No traces of captcha.
b) 0
Actual result
a) Captcha label shown in form, indicating that Captcha plugin is set in configuration.
b) recaptcha
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20293.
don' t hate me but yet another one for you @HLeithner
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20293.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20293.
| Labels |
Added:
?
Removed: J3 Issue |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-14 09:15:14 |
| Closed_By | ⇒ | HLeithner |
thx
Cc @tonypartridge so the original author is aware ;-)