[#20278] - [4.0] Conditional in Joomla Router::parse() makes all urls in 3rd party extensions invalid if $uri->getPath() > 0
- Closed
- 1 May 2018
- Medium
- Build: staging
- # 20278
Steps to reproduce the issue
File:
libraries/src/Router/Router.php
Conditional in Joomla Router::parse() makes all urls in 3rd party extensions invalid if $uri->getPath() > 0
Steps to reproduce the issue are not really important, also my router.php is very big to paste here.
The comment in line 146 of class Router says:
// Check if all parts of the URL have been parsed.
// Otherwise we have an invalid URL
The check is:
if (strlen($uri->getPath()) > 0)
Why is this check valid?
Why are urls invalid if the path exists?
It just doesn't make sense and breaks urls.
If I remove the check, the urls work fine.
Expected result
Working urls
Actual result
Invalid urls
System information (as much as possible)
Joomla 4.0.0-dev
Additional comments
The exact same router.php works perfectly in Joomla 3.8.5
joomla-cms-bot
- | Labels |
Added:
?
|
||
franz-wohlkoenig
- | Category | ⇒ | Router / SEF |
Yes, this is the line.
This is about a 3rd party extension, so the condition was never triggered in Joomla 3 as the new router (sef_advanced) is not relevant.
It seems that the problem existed before but was never triggered. Could you please point me to some documentation or relevant code for removing path segments properly after parsing them?
@minitek check:
joomla-cms/components/com_banners/router.php
Lines 63 to 103 in aa2146f
The parse method in routers is basically the reverse of the build method.
If you don't take all the query string variables in the build method and either remove them or convert them to URI segments then you end up with SEF URLs which still have a query string path (i.e. https://www.joomla.org/announcements.html?start=3 for page 2 of our announcements section).
It's important for parsing SEF URLs to remove all segments otherwise this is where you start running into the awkward behaviors of having several URLs for the same content page and the Joomla router would just accept it with no questions asked (if you search around there are some examples of some things that shouldn't work but will because the older router structure is so lenient).
Thank you guys!
Solved.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-01 21:11:47 |
| Closed_By | ⇒ | minitek |
I assume you are referring to this line (or this line in 3.x but the error condition only triggers if the new router is enabled).
This check is done after the component routers have been run, where a component router should be taking path segments and removing them after parsing them into whatever variables are needed. If there are still path segments remaining after parsing has finished then this indicates that a URI was not fully matched.