? ? ? Pending

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
1 May 2018

Pull Request for Issue #20228 .

Summary of Changes

Get autofocus settings from the field xml instead of from the plugin settings.
Autofocus only one CodeMirror per page regardless of field settings.

Testing Instructions

Open up a form with multiple CodeMirrors on it. One or more of their xml settings may include an autofocus attribute.

Expected result

At most, one CodeMirror will have focus when the page loads.

Actual result

Yes, this should be correct.

Documentation Changes Required

No.

avatar okonomiyaki3000 okonomiyaki3000 - open - 1 May 2018
avatar okonomiyaki3000 okonomiyaki3000 - change - 1 May 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2018
Category Administration Language & Strings Libraries Front End Plugins
avatar Septdir
Septdir - comment - 1 May 2018

I have tested this item successfully on 4d06775

Nice. After changes ping me. I will test again.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20270.

avatar Septdir Septdir - test_item - 1 May 2018 - Tested successfully
avatar okonomiyaki3000 okonomiyaki3000 - change - 7 May 2018
Labels Added: ? ?
avatar Quy
Quy - comment - 7 May 2018

I have tested this item successfully on 94dccf2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20270.

avatar Quy Quy - test_item - 7 May 2018 - Tested successfully
avatar okonomiyaki3000
okonomiyaki3000 - comment - 7 May 2018

@Septdir 🏓 (there was no :ping:, this was as close as I could get)

avatar Septdir
Septdir - comment - 7 May 2018

I have tested this item successfully on 94dccf2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20270.

avatar Septdir Septdir - test_item - 7 May 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 7 May 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 May 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 10 May 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-05-10 00:51:37
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 10 May 2018
avatar mbabker mbabker - merge - 10 May 2018

Add a Comment

Login with GitHub to post a comment