? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
30 Apr 2018

Summary of Changes

Change the defaults for new installs to disable com_mailto in articles.

As discussed with the JSST this is now a public tracker item: cc @SniperSister @mbabker

Testing Instructions

  • Install this branch
  • make sure the default for com_mailto settings in com_content Global configuration is off

Expected result

default is off

Actual result

default is on

Documentation Changes Required

none

Additional notes

When this got merged I'm going to build a PR against 4.0 that set the correct settings to the xml and PHP Code too if needed.

avatar zero-24 zero-24 - open - 30 Apr 2018
avatar zero-24 zero-24 - change - 30 Apr 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2018
Category SQL Installation Postgresql MS SQL
avatar brianteeman
brianteeman - comment - 30 Apr 2018

When this got merged I'm going to build a PR against 4.0 that set the correct settings to the xml and PHP Code too if needed.

I have a pr open to remove it completely in j4

avatar zero-24
zero-24 - comment - 30 Apr 2018

I have a pr open to remove it completely in j4

Would be great but I have been told that I should better rewrite it to JForm than removing it by @wilsonge . Well maybe we can finally remove it with 4.0 but for 3.8 & 3.9. we need to fix it anyway. The defaults and the support for captcha.

avatar mbabker
mbabker - comment - 30 Apr 2018

No, not removing com_mailto. Removing the email button.

avatar zero-24
zero-24 - comment - 30 Apr 2018

No, not removing com_mailto. Removing the email button.

I don't care for now what is done in 4.0 with com_mailto lets get this one into 3.8.8 and we do what ever we decide to do in 4.0 this was just a general note to avoid discussions about xmls and PHP code to change or not as that was decided to be done if ever in 4.0. :)

avatar Quy
Quy - comment - 30 Apr 2018

Update:
sample_learn.sql
jos_extensions.csv
jos_menu.csv

avatar zero-24 zero-24 - change - 30 Apr 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2018
Category SQL Installation Postgresql MS SQL SQL Installation Postgresql MS SQL Unit Tests
avatar zero-24
zero-24 - comment - 30 Apr 2018

Thanks @Quy just pushed that fixes.

avatar Quy
Quy - comment - 30 Apr 2018

I have tested this item successfully on 367b4d4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20266.

avatar Quy Quy - test_item - 30 Apr 2018 - Tested successfully
avatar infograf768
infograf768 - comment - 4 May 2018

I have tested this item successfully on 367b4d4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20266.

avatar infograf768 infograf768 - test_item - 4 May 2018 - Tested successfully
avatar infograf768 infograf768 - change - 4 May 2018
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 4 May 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20266.

avatar mbabker mbabker - close - 5 May 2018
avatar mbabker mbabker - merge - 5 May 2018
avatar mbabker mbabker - change - 5 May 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-05-05 20:17:49
Closed_By mbabker
Labels Added: ?

Add a Comment

Login with GitHub to post a comment