Feeling Lucky
?
?
[#20257] - Tiny JLanguage::loadLanguage() code improvement
- Fixed in Code Base
- 30 Apr 2018
- Medium
- Build: staging
- # 20257
- Diff
- Quy:patch-18
User tests: Successful: Unsuccessful:
Rebase PR #14653
Summary of Changes
From original PR:
This simplifies the code slightly. The additional if() is unnecessary. The $strings variable is always defined and the if() does contain nothing else than yet another if(). This change is not really testable and requires a code review.
Credit goes to @Hackwar
Testing Instructions
Code review.
Expected result
Works as expected on frontend and backend.
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | Pending | ⇒ | Ready to Commit |
ReLater
- comment
- 29 Apr 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20257.
zero-24
- comment
- 29 Apr 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20257.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-30 22:31:56 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
?
|
||
Together with the review by @Bakual on the original issue we can move this to RTC. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20257.