[#20237] - Pass the default value of layout while getting it from input
- Closed
- 26 Apr 2018
- Medium
- Build: staging
- # 20237
- Diff
- gauravjain028:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Either we should pass the default value '' (blank) or we should check if (!empty($layout)) {. As in case layout is not set in input, it's value will be null and it will pass the if condition and ultimately it will add layout= in the url.
Testing Instructions
I was using CanonicalLinks plugin, with param to be set yes to redirect canonicals. So due to this Joomla was adding layout= in home page url and it is being redirected to www.sitename.com/?layout= instead of www.sitename.com
Expected result
Url should not have have layout=
Actual result
It is adding layout= in the url.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
fix in #20229
@gauravjain028 If you want to fix this bug on your site, I would recommend simply deleting the lines. Because the code you supply is wrong.
If you want to refine it, you will have it #20200 This of course partially solves the problem, but does not eliminate the cause
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-26 17:55:35 |
| Closed_By | ⇒ | gauravjain028 | |
| Labels |
Added:
?
|
||
can you test #20229 please ?