? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
23 Apr 2018

Headings communicate the organization of the content on the page. Web browsers, plug-ins, and assistive technologies can use them to provide in-page navigation.

Skipping heading ranks can be confusing and should be avoided where possible: Make sure that a < h2> is not followed directly by an < h4>, for example.

Source (https://www.w3.org/WAI/tutorials/page-structure/headings/)

The heading was probably chosen for cosmetic reasons and not structural reasons which they should have been

This PR changes the heading for the post-installtion message i the control panel from h4 to h3

There is a very small visual change as a result but imho the benefits outweigh the small cost

avatar brianteeman brianteeman - open - 23 Apr 2018
avatar brianteeman brianteeman - change - 23 Apr 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Apr 2018
Category Administration com_cpanel
avatar brianteeman brianteeman - change - 23 Apr 2018
The description was changed
avatar brianteeman brianteeman - edited - 23 Apr 2018
avatar Quy
Quy - comment - 23 Apr 2018

I have tested this item successfully on 35119a7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20220.

avatar Quy Quy - test_item - 23 Apr 2018 - Tested successfully
avatar sandewt
sandewt - comment - 23 Apr 2018

I have tested this item successfully on 35119a7

Joomla! 3.8.7-rc Release Candidate


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20220.

avatar sandewt sandewt - test_item - 23 Apr 2018 - Tested successfully
avatar Quy Quy - change - 23 Apr 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 23 Apr 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20220.

avatar mbabker mbabker - change - 29 Apr 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-04-29 14:43:26
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 29 Apr 2018
avatar mbabker mbabker - merge - 29 Apr 2018
avatar brianteeman
brianteeman - comment - 29 Apr 2018

Thanks

Add a Comment

Login with GitHub to post a comment