? Pending

User tests: Successful: 2 ReLater, sandewt Unsuccessful: 0

avatar degobbis
degobbis
22 Apr 2018

Pull Request for Issue #20195

avatar degobbis degobbis - open - 22 Apr 2018
avatar degobbis degobbis - change - 22 Apr 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2018
Category Front End com_contact
avatar joomla-cms-bot joomla-cms-bot - edited - 22 Apr 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Apr 2018
Title
Solves issue #20195
Solves issue #20195: [com_fields] Contact-Mail Custom field issue after joomla 3.8.3
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Apr 2018

changed Title to be clear what this PR is about.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20214.

avatar sandewt
sandewt - comment - 23 Apr 2018

I have tested this item successfully on d663127

Joomla! 3.8.8-dev Development

Solved issue #20195 Contact-Mail Custom field issue after joomla 3.8.3

Solved issue #17743 Contact form loses data after postback with error

I have tested both issues.

Note: See also the test instructions for issue #17743.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20214.

avatar sandewt sandewt - test_item - 23 Apr 2018 - Tested successfully
avatar tonypartridge
tonypartridge - comment - 23 Apr 2018

What if catid on item is empty? There was a check originally wrapping the whole state. But that’s being changed now and you are calling item catid directly, is it always set?!?! Seems strange that we were previously checking it if it is always set.

avatar degobbis
degobbis - comment - 23 Apr 2018

@tonypartridge Yes, ist is always set. You can't create a contact without setting a category.

avatar ReLater
ReLater - comment - 23 Apr 2018

I have tested this item successfully on d663127


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20214.

avatar ReLater ReLater - test_item - 23 Apr 2018 - Tested successfully
avatar Quy Quy - change - 23 Apr 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 23 Apr 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20214.

avatar mbabker mbabker - change - 29 Apr 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-04-29 14:44:20
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 29 Apr 2018
avatar mbabker mbabker - merge - 29 Apr 2018
avatar artur-stepien
artur-stepien - comment - 17 May 2018

Why is it fixed in a view instead of model? Views aren't for that ...

Add a Comment

Login with GitHub to post a comment