[#20206] - Name attribute is deprecated, in the future fetch the pathway through the respective application
- Closed
- 10 May 2019
- Medium
- Build: staging
- # 20206
- Diff
- NickSdot:fix-for-20203
- Success Hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #20203 .
Summary of Changes
Because $name attribute in \Joomla\CMS\Application\CMSApplication::getPathway is deprecated, \Joomla\CMS\Application\SiteApplication::getPathway should also not provide a hardcoded name.
Testing Instructions
- Use following code
$app = JFactory::getApplication();
$pathway = $app->getPathway();
//debug
echo '<pre>';
var_dump($pathway);
echo '</pre>';- Open page where you use it.
- Open /logs/deprecated.php check if there is message 'Name attribute is deprecated, in the future fetch the pathway...'.
- Delete log file and apply patch
- Reload page where you use the code
- Check log again. No deprecated message should be there anymore.
- Compare output of var_dump before/after.
Expected result
Behavior like before, but no deprecated message in log file.
Actual result
Deprecated message 'Name attribute is deprecated, in the future fetch the pathway through the respective application' in log, when Factory::getApplication()->getPathway(); is used without attributes.
Documentation Changes Required
I don't think so.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20206.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20206.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20206.
| Title |
|
||||||
@HLeithner please a final response
1 year old rtc pr
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-10 12:45:16 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
Removed: J3 Issue |
||
changed Title to be clear what this PR is about.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20206.