[#20204] - [fix] publish does not work with tables using null as default checked_out value
- Fixed in Code Base
- 22 Apr 2018
- Medium
- Build: staging
- # 20204
- Diff
- phproberto:publish-is-null
- Pending continuous-integration/drone/pr this build is pending Details
- Pending Hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Technically what joomla does to set an item as checked out is to set the checked_out column to 0. If you have a proper DB schema you probably have a foreign key that connects your checkout_out column to #__users table. But joomla does not allow to do this because 0 cannot be assigned because there is no user with id 0.
So:
- the correct checked_out column values should be
NULLor values > 0. - values checked by joomla are
0or values > 0
For backward compatibility we cannot change current allowed values. This pull request changes publish checked out check to accept:
NULL0- values > 0
Which should be ok to keep current behaviour but not punishing those that want to use correct foreign keys. Keep compatibility allowing correct DB schemas to be used.
Testing Instructions
After applying this patch go to articles and publish/unpublish items. Do the same for any other management you want like banners, etc. Ensure that things work as expected.
Documentation Changes Required
No changes required.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
happy to see you back...
and yes we need fo fix a lot of this things... with your help too
YES WE CAN
I have tested this item
No problem here with core. Not tested with 3rd party.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20204.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20204.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20204.
Thanks for testing and commenting here!
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-22 15:35:19 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
still dreaming about proper FK adoption