Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#20202] - [plg_content_pagebreak] Let users template override TOC

? ? Pending

User tests: Successful: Unsuccessful:

avatar ReLater
ReLater
19 Apr 2018

See discussion here: #17670

Summary of Changes

  • Added possibility to use a template override for TOC.
  • Don't break B\C.
  • BTW: Fix older bug: "Show All" never has active class even if active.

Testing Instructions

  • Plugin "Content - Page Break". Make settings:

19-04-_2018_19-35-49

  • Add some pagebreak markers to an article and open article in frontend.
  • Inspect TOC (also source code).

19-04-_2018_19-37-41

  • Apply patch.

  • Inspect TOC (also source code).

  • Expected: No changes.

  • Create a template override for new file tmpl/toc.php.
    Example with Protostar:

19-04-_2018_19-43-30

  • Check that the override works.
avatar ReLater ReLater - open - 19 Apr 2018
avatar ReLater ReLater - change - 19 Apr 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Apr 2018
Category ⇒ Front End Plugins
avatar ReLater ReLater - change - 19 Apr 2018
The description was changed
avatar ReLater ReLater - edited - 19 Apr 2018
avatar dgrammatiko
dgrammatiko - comment - 19 Apr 2018

we need to make sure that all plugins are actually overridable! Great work here ?

avatar ReLater ReLater - change - 19 Apr 2018
Labels Added: ? ?
avatar ReLater ReLater - change - 19 Apr 2018
The description was changed
avatar ReLater ReLater - edited - 19 Apr 2018
avatar Quy
Quy - comment - 20 Apr 2018

I have tested this item ✅ successfully on 50c8e51

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20202.

avatar Quy Quy - test_item - 20 Apr 2018 - Tested successfully
avatar ReLater ReLater - change - 21 Apr 2018
Title
…
[RFC] [plg_content_pagebreak] Let users template override TOC
[plg_content_pagebreak] Let users template override TOC
avatar ReLater ReLater - edited - 21 Apr 2018
avatar ReLater ReLater - change - 21 Apr 2018
The description was changed
avatar ReLater ReLater - edited - 21 Apr 2018
avatar LivioCavallo
LivioCavallo - comment - 26 Apr 2018

I have tested this item ✅ successfully on 50c8e51

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20202.

avatar LivioCavallo LivioCavallo - test_item - 26 Apr 2018 - Tested successfully
avatar LivioCavallo
LivioCavallo - comment - 26 Apr 2018

Well done. Thanks. I tested it successfully. If all will be ok I'll close #17670

avatar Quy Quy - change - 26 Apr 2018
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 26 Apr 2018

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20202.

avatar mbabker mbabker - change - 12 May 2018
Labels Added: ? ?
Removed: ? ?
avatar mbabker mbabker - change - 12 May 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-05-12 17:15:31
Closed_By ⇒ mbabker
avatar mbabker mbabker - close - 12 May 2018
avatar mbabker mbabker - merge - 12 May 2018

Add a Comment

Login with GitHub to post a comment