[#20192] - [4.0] Multilingual: Mod_languages - Adding the Full Languages Names parameter to dropdown display
- Fixed in Code Base
- 8 Jun 2018
- Medium
- Build: 4.0-dev
- # 20192
- Diff
- infograf768:40_mod_languages
User tests: Successful: Unsuccessful:
Pull Request for Issue #9225
Summary of Changes
As title says.
This PR lets ALSO use the param when using dropdown, with images or without images.
Changed order of params. Took off the Spacer and its lang string. Corrected a typo in a lang string.
Testing Instructions
Create a simple multilingual site and display the lang switcher in frontend.
When present when editing the module, choose No for the Full Languages Names parameter
After patch, the Full Languages Names parameter will also work when using the dropdown.
Examples:
And lets still use it when not using dropdown.
One can also test when choosing yes for the Full Name param.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Language & Strings Modules Front End |
@brianteeman Cause it looks and feels a bit better and then : En Fr Ru Pl? Also the readability is higher. So I assume its better to use a style that provides better readability out of the box. But isn't big of a deal doing it with CSS either
As its purely for style then I think it would be better to do it in CSS - that way a user can change it if they dont want it to be uppercase. It "might" not be appropriate for some languages to be transformed to uppercase
@brianteeman It isn't for styling, its more for readability. And some language names are hard to read like Pl, it can be PL or PI depends on how to look on it, uppercase chars are easier to read
We have always used strtoupper as it is what users asked for some time after the first multilingual feature release. We did agree at that time it made totally sense.
This PR is NOT changing this behaviour and I see no reason to modify it for the reasons explained above by @artur-stepien
@artur-stepien
Can you please test the PR and. if it does work for you in all cases, then mark it OK here:
https://issues.joomla.org/tracker/joomla-cms/20192
tks.
@infograf768 I will but in the evening.
thank you for the explanation
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20192.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20192.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20192.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-08 16:30:44 |
| Closed_By | ⇒ | laoneo |
Thanks @infograf768!!
Can I ask the reasoning for the strtoupper - isnt that a style choice?