? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
16 Apr 2018

The edit profile form is not loading the bootstrap tooltip code. So any tooltip (not popovers) are displayed as html, for example when TFA is enabled.

This was spotted by @o2tsen and @sandewt while testing #20051 but as it is a bug effecting more than that PR I have created a new PR. (a pr should only fix one problem)

avatar brianteeman brianteeman - open - 16 Apr 2018
avatar brianteeman brianteeman - change - 16 Apr 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Apr 2018
Category Front End com_users
avatar ot2sen
ot2sen - comment - 16 Apr 2018

I have tested this item successfully on 3555328

Works. Thanks :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20177.

avatar ot2sen ot2sen - test_item - 16 Apr 2018 - Tested successfully
avatar alikon
alikon - comment - 16 Apr 2018

I have tested this item successfully on 3555328

on code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20177.

avatar alikon alikon - test_item - 16 Apr 2018 - Tested successfully
avatar Quy Quy - change - 16 Apr 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 16 Apr 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20177.

avatar sandewt
sandewt - comment - 16 Apr 2018

I have tested this item ? unsuccessfully on 3555328

Joomla! 3.9.0-dev

page User Registration
link: Privacy Policy -> tooltip NOK
link: Terms of Service -> tooltip NOK

page Edit Your Profile
link: Privacy Policy -> tooltip OK

Missing in \components\com_users\views\registration\tmpl\default.php:
JHtml::_('bootstrap.tooltip');

Note: When I add this code manually, it works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20177.

avatar sandewt sandewt - test_item - 16 Apr 2018 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 16 Apr 2018

thats obviously something else unrelated in the current 3.9 tree. this will be merged into the staging tree

avatar sandewt
sandewt - comment - 16 Apr 2018

@brianteeman

I have no experience with that.

[EDIT] Tested successfully Joomla! 3.8.7-dev.

avatar sandewt
sandewt - comment - 21 Apr 2018

but as it is a bug effecting more than that PR

Joomla! 3.9.0-dev Development

I found the same issue with the tooltip in case of the <Prev (previous) and the Next > buttons.

See the image.

screen shot 2018-04-21 at 19 44 42

Note: I found this issue also on my live site concerning Joomla 3.8.7. I can not reproduce this last on a test site.

avatar brianteeman
brianteeman - comment - 22 Apr 2018

@sandewt please only test with staging

avatar sandewt
sandewt - comment - 22 Apr 2018

@sandewt please only test with staging

Is OK. @brianteeman, thanks for the feedback.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20177.

avatar mbabker mbabker - change - 22 Apr 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-04-22 15:37:17
Closed_By mbabker
Labels Added: ? ?
avatar mbabker mbabker - close - 22 Apr 2018
avatar mbabker mbabker - merge - 22 Apr 2018
avatar brianteeman
brianteeman - comment - 22 Apr 2018

thanks

avatar sandewt
sandewt - comment - 26 Apr 2018

I found the same issue with the tooltip in case of the <Prev (previous) and the Next > buttons.

This does not turn out to be stable in Joomla! 3.8.7.

New PR?

avatar mbabker
mbabker - comment - 26 Apr 2018

This PR was not merged before the 3.8.7 release and as indicated by the milestone will be included in 3.8.8.

avatar sandewt
sandewt - comment - 26 Apr 2018

@mbabker

The patch does not offer a solution for the Prev and Next buttons in J3.8.7.

So, it was necessary to add JHtml::_('bootstrap.tooltip') in ...\plugins\content\pagenavigation\tmpl\ default.php on my (live) site.

avatar mbabker
mbabker - comment - 26 Apr 2018
  1. This patch doesn't change anything with the pagenavigation plugin
  2. It wasn't included in 3.8.7 as I said
  3. If there is still an issue with tooltips in that plugin's layout context then there needs to be a new issue/PR opened to get it addressed; media needs to be loaded in that layout when it is required, nothing should be relying on other parts of the system to load the media it needs.

Add a Comment

Login with GitHub to post a comment