? Pending

User tests: Successful: Unsuccessful:

avatar danieldsf
danieldsf
15 Apr 2018

Pull Request for Issue # .

Summary of Changes

I was getting an error: Notice Trying to get property of non object on the administrator login page, so I decided to fix this issue according to this suggestions: Notice Trying to get property of non object. I hope it doesn't create any other bugs.

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar danieldsf danieldsf - open - 15 Apr 2018
avatar danieldsf danieldsf - change - 15 Apr 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2018
Category Libraries
avatar danieldsf danieldsf - change - 15 Apr 2018
The description was changed
avatar danieldsf danieldsf - edited - 15 Apr 2018
avatar zero-24
zero-24 - comment - 15 Apr 2018

Hi, thanks for your contribution ?

What did you do to get the Notice Trying to get property of non object? How can we reproduce the issue? As on a first look this does not look like the best fix. As we should fix the root cause if possible and not the symptom ;)

avatar danieldsf
danieldsf - comment - 15 Apr 2018

Hello, @zero-24 !
I am not really sure why it appears. I was updating my old 3.6.4 Joomla Version to latest one (3.8.6) and then when I got to the login page it just appeared.

avatar SharkyKZ
SharkyKZ - comment - 15 Apr 2018

This will break the entire function because language code is never numeric.

avatar zero-24
zero-24 - comment - 15 Apr 2018

I am not really sure why it appears. I was updating my old 3.6.4 Joomla Version to latest one (3.8.6) and then when I got to the login page it just appeared.

Can you please check the languages that you have installed?

avatar danieldsf
danieldsf - comment - 15 Apr 2018

That makes sense. You are right, it's not really numeric. In php 5.6 it works, though. I will close the pull request then.

avatar danieldsf
danieldsf - comment - 15 Apr 2018

Languages: pt-PT, pt-BR, en-US, en-GB

avatar zero-24
zero-24 - comment - 15 Apr 2018

Languages: pt-PT, pt-BR, en-US, en-GB

hmm do you know how to do a breakpoint and setup xdebug to see what comes there?
can you reproduce that issue on a new install with that languages too?
what 3rd party Extension do you have installed

avatar danieldsf danieldsf - change - 16 Apr 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-04-16 07:11:33
Closed_By danieldsf
Labels Added: ?
avatar danieldsf danieldsf - close - 16 Apr 2018

Add a Comment

Login with GitHub to post a comment