? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
13 Apr 2018

image

Since 2003 the internet has changed. We no longer get a message to say that we have a message. Instead we just give you the message. You probably never use the messages component (especially for private message to a specific user) as they are the equivalent of https://www.youtube.com/watch?v=gFBLiHpkcOk

The Joomla com_messages component is used in two instances

  1. Notification of a new article
  2. Sending a message to another user

Current email for Notification of a new article

Subject: A new private message has arrived from [sitename]
Body:

Please log in to [link] to read your message.


New email for Notification of a new article

Subject: New message from [user] at [sitename]
Body:

New Article
A new Article has been submitted by 'user' entitled 'blog post'.
Please log in to [link] to read your message.


Current email when sending a message to another user

Subject: A new private message has arrived from [sitename]
Body:

Please log in to [link] to read your message.


New email when sending a message to another user

Subject: New message from [user] at [sitename]
Body:

[subject]
[message]
[login link]


Backwards Compatibility

No issues. The message contains the old login message PLUS the content of the message. So if you were using this message in a custom workflow there is no change required to that workflow

30e53cc 13 Apr 2018 avatar brianteeman subj
avatar brianteeman brianteeman - open - 13 Apr 2018
avatar brianteeman brianteeman - change - 13 Apr 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2018
Category Administration com_messages Language & Strings
39509d6 13 Apr 2018 avatar brianteeman cs
avatar brianteeman brianteeman - change - 13 Apr 2018
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 14 Apr 2018

I am not sure this is b/c because of the order of the variables in the sprintf.
is that so urgent it can’t wait 4.0?

avatar brianteeman
brianteeman - comment - 14 Apr 2018

So I can simply resolve that by making ti a completely new string and then there is no issue - will do that right now

avatar brianteeman
brianteeman - comment - 14 Apr 2018

PR updated

avatar ReLater
ReLater - comment - 19 Apr 2018

I have tested this item successfully on 0e97189


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20162.

avatar ReLater ReLater - test_item - 19 Apr 2018 - Tested successfully
avatar Quy
Quy - comment - 22 Apr 2018

I have tested this item successfully on 0e97189


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20162.

avatar Quy Quy - test_item - 22 Apr 2018 - Tested successfully
avatar Quy Quy - change - 22 Apr 2018
The description was changed
Status Pending Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 22 Apr 2018
avatar joomla-cms-bot joomla-cms-bot - edited - 22 Apr 2018
avatar Quy
Quy - comment - 22 Apr 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20162.

avatar mbabker mbabker - change - 29 Apr 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-04-29 14:46:39
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 29 Apr 2018
avatar mbabker mbabker - merge - 29 Apr 2018
avatar brianteeman
brianteeman - comment - 29 Apr 2018

thanks

Add a Comment

Login with GitHub to post a comment