Isn't highlighter.js used for smart search search results? Or has it been replaced by something else?

Yes its used but there are two duplicates.
media/com_finder/js/highlighter.js (removed since its not used)
media/system/js/highlighter.js (has both minified version and development version which is used in cms)

Ahh, okay. That's fine then. Thanks.

Merged to 3.3-dev

@AshanFernando, @mbabker

Is part of 3.3 project changing autocompleter.js to jQuery as well, or it stays on mootools in 3.5 series?

Is part of 3.3 project changing autocompleter.js to jQuery as well, or it stays on mootools in 3.5 series?

We want to change everything to jQuery so Mootools can be removed in 4.0. I'm currently not aware of an existing PR to change that particular JavaScript code. So if you can, rewrite it and do a PR for it. That would be appreciated

I hope you are referring to the following https://github.com/joomla/joomla-cms/blob/staging/media/com_finder/js/autocompleter.js file. What are the usage areas of this library?
I could check on this during the weekend if its a high priority modification removing MooTools for Joomla 4.0

Mod finder is using it for autocomplete when you type something in the
search input field. I don't know if it's used for something else as well, I
will check when I am in front of the computer, but I know that there are
two improvements which we could add to it. One is to move is its inclusion
to module template so it can be overridden, and the other to choose the
minimum number of letters needed before autocomplete is activated, it's
hardcoded at the moment
On 20 Mar 2014 09:50, "Ashan Fernando" notifications@github.com wrote:

I hope you are referring to the following
https://github.com/joomla/joomla-cms/blob/staging/media/com_finder/js/autocompleter.jsfile. What are the usage areas of this library?
I could check on this during the weekend if its a high priority
modification removing MooTools for Joomla 4.0

—
Reply to this email directly or view it on GitHub#2016 (comment)
.

One is to move is its inclusion to module template so it can be overridden

It's loaded here:

• https://github.com/joomla/joomla-cms/blob/staging/modules/mod_finder/tmpl/default.php#L128
• https://github.com/joomla/joomla-cms/blob/staging/components/com_finder/views/search/tmpl/default_form.php#L61

Both places are in the layout file, which can be overriden by templates. And the call uses JHtmlScript which also allows to override it. So this is is not an issue at all currently. Or do I miss something?

Well, I accept that I was too sleepy when I looked at 6am this morning :) I
will double check in the afternoon when I am back
On 20 Mar 2014 10:21, "Thomas Hunziker" notifications@github.com wrote:

One is to move is its inclusion to module template so it can be overridden

It's loaded here:
https://github.com/joomla/joomla-cms/blob/staging/modules/mod_finder/tmpl/default.php#L128and
https://github.com/joomla/joomla-cms/blob/staging/components/com_finder/views/search/tmpl/default_form.php#L61
Both places are in the layout file, which can be overriden by templates.
And the call uses JHtmlScript which also allows to override it. So this is
is not an issue at all currently. Or do I miss something?

—
Reply to this email directly or view it on GitHub#2016 (comment)
.

Yeah, you are right, it was too early when I looked...

Thanks for the info! I will check this during the weekend :)

@AshanFernando

Did you maybe have time to check this?

In the autocomplete.js several Mootools classes are converted to jQuery
which includes "Observer", "OverlayFix", "Autocompleter.Request",
"Autocompleter.Request.JSON", "Autocompleter.Request.HTML".

"Autocompleter" class is yet to be converted.

On Fri, Apr 4, 2014 at 5:06 PM, Marko D notifications@github.com wrote:

@AshanFernando https://github.com/AshanFernando

Did you maybe have time to check this?

Reply to this email directly or view it on GitHub#2016 (comment)
.

*Regards, *

• http://lk.linkedin.com/in/ashanfernando**Ashan Fernando*

Sounds good, thanks ofr the update!

Any chance for this to make it into Joomla 3.4? What needs to be done?

This PR is already merged into the 3.4 branch.