[#20158] - Remove not necessary line of code
- Fixed in Code Base
- 3 Sep 2018
- Medium
- Build: staging
- # 20158
- Diff
- joomdonation:patch-22
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This line of code is used to register JModel class with Joomla loader. It is not valid anymore and should be removed
Testing Instructions
Apply patch and test the following cases:
-
Access to a random page on frontend of your site, make sure it is still loading as expected (it is related to the command removed in update notification plugin)
-
For the changes related to custom fields (two files), please create custom field for article, then try to add/edit an article, check and make sure custom fields still being saved. Delete the article and confirm that it is being deleted, too (I am not sure if it covers all the cases)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
| Labels |
Added:
?
|
||
| Category | Administration com_fields | ⇒ | Administration com_fields Front End Plugins |
OK. I updated the PR with testing instructions. However, I still believe these kind of PR can be merged base on code review. These lines used in the past to register the classes such as JModel, JComponentHelper to JLoader for auto-loading. As of right now, these classes are namespaced and autoloaded, so it's clearly that these lines of code are not needed anymore
Thanks for that. If you plan to do more of these pr's, can you do them against 4.0-dev? George would be thankful as there will be less potential merge conflicts then.
There's no point in restricting valid code fixes to 4.0 only unless it's an issue only in that branch or requires a B/C breaking change. This isn't one.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20158.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20158.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20158.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20158.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-03 17:17:08 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
It is always better to have at least one successful test. Just write what you did to test it and then someone else can test too. Not so much work.