User tests: Successful: Unsuccessful:
Some settings under Media configuration depend on Restrict Uploads
setting. This PR hides these settings when Restrict Uploads
is No.
Under Global Configuration > Media, toggle Restrict Uploads
to No.
Applicable settings hidden.
Applicable settings are always visible.
none
Ping @zero-24
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_media |
That is a valid concern, however, I don't know for sure.
To configure, enable temporarily Restrict Uploads to display/edit these settings and disable when done.
I have tested this item
@robbiejackson your concern makes sense. But I see it that way, when a 3rd party extension is using the settings then it should also use the core upload API.
Yes, I would agree with those points.
Why is Ignored Extensions not hidden?
Because Ignored Extensions
setting is utilized outside and inside the Restrict Uploads
setting.
$ignored = array_map('trim', explode(',', $params->get('ignore_extensions')));
if ($filetype == '' || $filetype == false || (!in_array($filetype, $allowable) && !in_array($filetype, $ignored)))
if ($params->get('restrict_uploads', 1))
{
elseif (!in_array($filetype, $ignored))
}
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
I have tested this item
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-10 00:54:31 |
Closed_By | ⇒ | mbabker | |
Labels |
Added:
?
?
|
I think what you're suggesting matches the media helper code, but I'd just be a bit worried that some other extensions (not necessarily core Joomla) might be using those fields that you're now hiding to hold configuration data which they use in that extension. And then they'd be able to configure that data only after setting Restrict Uploads (which an administrator might not want to do).
Do you think this is a valid concern?