? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
12 Apr 2018

Summary of Changes

Some settings under Media configuration depend on Restrict Uploads setting. This PR hides these settings when Restrict Uploads is No.

Testing Instructions

Under Global Configuration > Media, toggle Restrict Uploads to No.

Expected result

Applicable settings hidden.

Actual result

Applicable settings are always visible.

Documentation Changes Required

none

Ping @zero-24

avatar Quy Quy - open - 12 Apr 2018
avatar Quy Quy - change - 12 Apr 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2018
Category Administration com_media
avatar Quy Quy - change - 12 Apr 2018
The description was changed
avatar Quy Quy - edited - 12 Apr 2018
avatar robbiejackson
robbiejackson - comment - 14 Apr 2018

I think what you're suggesting matches the media helper code, but I'd just be a bit worried that some other extensions (not necessarily core Joomla) might be using those fields that you're now hiding to hold configuration data which they use in that extension. And then they'd be able to configure that data only after setting Restrict Uploads (which an administrator might not want to do).

Do you think this is a valid concern?

avatar Quy
Quy - comment - 14 Apr 2018

That is a valid concern, however, I don't know for sure.

To configure, enable temporarily Restrict Uploads to display/edit these settings and disable when done.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Apr 2018

I have tested this item successfully on 646da06


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20156.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 15 Apr 2018 - Tested successfully
avatar laoneo
laoneo - comment - 16 Apr 2018

@robbiejackson your concern makes sense. But I see it that way, when a 3rd party extension is using the settings then it should also use the core upload API.

avatar robbiejackson
robbiejackson - comment - 16 Apr 2018

Yes, I would agree with those points.

avatar brianteeman
brianteeman - comment - 8 May 2018

Why is Ignored Extensions not hidden?

avatar Quy
Quy - comment - 8 May 2018

Because Ignored Extensions setting is utilized outside and inside the Restrict Uploads setting.

		$ignored   = array_map('trim', explode(',', $params->get('ignore_extensions')));

		if ($filetype == '' || $filetype == false || (!in_array($filetype, $allowable) && !in_array($filetype, $ignored)))

		if ($params->get('restrict_uploads', 1))
		{
			elseif (!in_array($filetype, $ignored))
		}
avatar carlitorweb
carlitorweb - comment - 8 May 2018

I have tested this item successfully on 646da06


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20156.

avatar carlitorweb carlitorweb - test_item - 8 May 2018 - Tested successfully
avatar Quy Quy - change - 8 May 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 8 May 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20156.

avatar brianteeman
brianteeman - comment - 8 May 2018

I have tested this item successfully on 646da06


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20156.

avatar brianteeman brianteeman - test_item - 8 May 2018 - Tested successfully
avatar mbabker mbabker - change - 10 May 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-05-10 00:54:31
Closed_By mbabker
Labels Added: ? ?
avatar mbabker mbabker - close - 10 May 2018
avatar mbabker mbabker - merge - 10 May 2018

Add a Comment

Login with GitHub to post a comment