Feeling Lucky
?
?
[#20154] - Fix typos in InstallerControllerUpdate
- Fixed in Code Base
- 22 Apr 2018
- Medium
- Build: staging
- # 20154
- Diff
- joomdonation:patch-21
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This small PR just fix some typos in InstallerControllerUpdate class. The get method of Joomla\Registry\Registry class only have 2 parameters (see https://github.com/joomla/joomla-cms/blob/staging/libraries/vendor/joomla/registry/src/Registry.php#L201) but we are passing 3 parameters when calling it and it's wrong.
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
Quy
- comment
- 13 Apr 2018
Fix (2 instances):
$cache_timeout = $params->get('cachetimeout', 6, 'int');
| Labels |
Added:
?
|
||
Quy
- comment
- 13 Apr 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20154.
| Category | Administration com_installer | ⇒ | Administration com_installer Front End Plugins |
| Category | Administration com_installer Front End Plugins | ⇒ | Administration com_installer |
| Category | Administration com_installer | ⇒ | Administration com_installer Front End Plugins |
| Category | Administration com_installer Front End Plugins | ⇒ | Administration com_installer |
alikon
- comment
- 13 Apr 2018
I have tested this item
on code review
p.s
hoping better than before
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20154.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 13 Apr 2018
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20154.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-22 15:39:02 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 83f10b9
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20154.