Without testing

• it looks good in case of cancel, we need to redirect back to the return url (after checking it)
• but in case of save2new is it needed ? looking at the code (without testing) $this->getRedirectToListAppend() seems to already adding (passing) the return url,

also a little irrelevant but you would not verify it when just passing it, usually we would check it for being "internal" only before final usage ?

@ggppdk Thank you for reviewing the code. You are correct, for Save & Close the change is not needed because the code is already in place there. I have updated the code and test instructions to reflect this.

also a little irrelevant but you would not verify it when just passing it, usually we would check it for being "internal" only before final usage ?

I am not sure what you are asking here. Are you talking about the isInternal check? That is just taken from how it is used in the Save action.

I am not sure what you are asking here. Are you talking about the isInternal check? That is just taken from how it is used in the Save action.

I meant (for the code that you have now removed) when appending the '&return' variable
'&return=' . $someurl, no need to check that someurl is internal

$return_url = $this->getInput(...);

// No need check return_url is internal, just append it
// it will be checked when it is time to be used (redirecting to it)
$this->setRedirect($someurl . '&return = ' . $url);

Like you correctly check it in cancel,
because we have reached the point that it will be used (redirecting to it)

I have tested this item ✅ successfully on d9e3f67

Also i see that custom article controller for frontend
(and also some controllers of 3rd party components)

already support using return url for the cancel task
so this is change is consistent, all core and 3rd party components using the default controller should benefit for this

I have tested this item ✅ successfully on d9e3f67

RTC