[#20135] - [4.0] Add space before the ellipsis
- Fixed in Code Base
- 21 Jun 2018
- Medium
- Build: 4.0-dev
- # 20135
- Diff
- Quy:patch-13
- Pending Hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Summary of Changes
To be consistent with the following language strings, add the space before the ellipsis.
PLG_QUICKICON_EXTENSIONUPDATE_CHECKING="Checking extensions ..."
PLG_QUICKICON_EXTENSIONUPDATE_ERROR="Unknown extensions ..."
PLG_QUICKICON_JOOMLAUPDATE_CHECKING="Checking Joomla..."
PLG_QUICKICON_JOOMLAUPDATE_ERROR="Unknown Joomla..."
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
In Print-Publishing there is also a Space between Letter and Ellipsis. The Space is small (1/8) and non-breakable.
and the elipsis should be …
Not had time to check with a screen reader as I am at drupalcon regarding using three dots or the html entity
However our style guide states that there should be a space before the dots
| Labels |
Added:
?
?
|
||
| Title |
|
||||||
In Print-Publishing there is also a Space between Letter and Ellipsis. The Space is small (1/8) and non-breakable
Depends on the language I guess. In French no space at all for ellipsis, but 1/4 unbreakable before : or ! or ;, etc.
Thats why we have language files :) and why the language string style guide is ONLY for en-GB
comment undesired. I was just exchanging with @franz-wohlkoenig about print rules in different languages, not about web en-gb rules.
@infograf768 thanks for Info, French Style was new to me.
and the elipsis should be …
@brianteeman Please check which is the preferred syntax. Thanks.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20135.
One more test please for this simple PR.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20135.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20135.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-21 04:28:48 |
| Closed_By | ⇒ | laoneo |
i need t check but i believe that for screenreaders to be able to read the word then there must be a space between the word and the elipsis