? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
10 Apr 2018

Pull Request for Issue #19773.

Summary of Changes

Currently, when a user searches for contacts and no contacts are found, the search form becomes hidden, making it impossible to return to previous state.

Testing Instructions

Create some contacts.
Set 'Filter Field' to 'Show' in Contact configuration.
Enter contact category view and use the filter form, make sure no results are returned.

Expected result

Filter form is shown.

Actual result

Filter form is not shown, making it impossible to search for contacts again or to clear the search form.

Documentation Changes Required

No.

Additional Notes

Codestyle review required.

avatar SharkyKZ SharkyKZ - open - 10 Apr 2018
avatar SharkyKZ SharkyKZ - change - 10 Apr 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2018
Category Front End com_contact
avatar SharkyKZ SharkyKZ - change - 10 Apr 2018
Title
[com_contact] Don't hide
[com_contact] Don't hide contact filter form
avatar SharkyKZ SharkyKZ - edited - 10 Apr 2018
avatar SharkyKZ SharkyKZ - change - 10 Apr 2018
Labels Added: ?
avatar Pinkeltje
Pinkeltje - comment - 10 Apr 2018

I have tested this item successfully on dd45283


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20126.

avatar Pinkeltje Pinkeltje - test_item - 10 Apr 2018 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 10 Apr 2018

All done. Thanks.

avatar SharkyKZ
SharkyKZ - comment - 11 Apr 2018

Updated.

avatar Quy
Quy - comment - 11 Apr 2018

I have tested this item successfully on b1418ce


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20126.

avatar Quy Quy - test_item - 11 Apr 2018 - Tested successfully
avatar Quy Quy - change - 11 Apr 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 11 Apr 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20126.

avatar mbabker mbabker - change - 22 Apr 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-04-22 15:40:49
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 22 Apr 2018
avatar mbabker mbabker - merge - 22 Apr 2018
avatar Jaironlanda
Jaironlanda - comment - 23 May 2018

Hi, I still have this problem after update to 3.8.8 Joomla version. How to fix it.

avatar mbabker
mbabker - comment - 23 May 2018

Check if your template has an override for components/com_contact/views/category/tmpl/default_items.php and if so you'll need to make similar changes to that override file.

Add a Comment

Login with GitHub to post a comment