? Success

User tests: Successful: Unsuccessful:

avatar AshanFernando
AshanFernando
18 Sep 2013

Under GSoC MooTools to jQuery project, this PR removes the MooTools dependencies in core.js file.

Feature Tracker Item:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31583&start=500

avatar AshanFernando AshanFernando - open - 18 Sep 2013
avatar betweenbrain betweenbrain - close - 11 Dec 2013
avatar betweenbrain betweenbrain - merge - 11 Dec 2013
avatar betweenbrain betweenbrain - close - 11 Dec 2013
avatar betweenbrain
betweenbrain - comment - 11 Dec 2013

Thanks @AshanFernando!

avatar betweenbrain
betweenbrain - comment - 11 Dec 2013

Hello @AshanFernando,

My apologies for any confusion that I may have caused with this pull request. It seems that I was too quick to merge it as we may need to deprecate JHtmlBehavior::framework for 4.0. Please see 6b86515 for the corresponding discussion.

I'd very much like to your work into Joomla as soon as possible, but I will need to speak to the others how best to approach this.

In the meantime, it seems as though Github will not allow me to reopen this pull request. Would it be possible to see if you can reopen it by pushing more commits to this branch, or make a new pull request, with an update from the comment I left at https://github.com/joomla/joomla-cms/pull/2010/files#r8267444 ?

avatar AshanFernando
AshanFernando - comment - 12 Dec 2013

Hi Matt, I will check on the issue and please update the findings you get after the discussion with others

avatar Bakual
Bakual - comment - 12 Dec 2013

@AshanFernando I have an idea how it could be done after your PR is merged:

  • Add a new function JHtmlBehavior::core which loads jQuery and core.js.
  • Replace the call for jQuery and core.js in JHtmlBehavior::framework with this new function. This will move this parts out and we will be able to easily deprecate the function in a later stage.
  • In JHtmlBehavior::multiselect and similar functions we change JHtml::_('script', 'system/multiselect.js', true, true); to JHtml::_('script', 'system/multiselect.js', false, true); and add a call to JHtmlBehavior::core instead.

I think that should work then. What do you think?

Add a Comment

Login with GitHub to post a comment