Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#20091] - Fix for JUserHelper::addUserToGroup() when user group title is a number.

? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
5 Apr 2018

Issue reported by user on forum https://forum.joomla.org/viewtopic.php?f=708&t=960491.

Summary of Changes

This fixes an issue with JUserHelper::addUserToGroup() when user group title is a number.

Testing Instructions

Create an user assigned to group with ID 2 (that would be "Registered" group on fresh installation).
Create user groups titled "2" and "0".
Use JUserHelper::addUserToGroup($userId, $groupId); to add user to newly created groups:
a) group "2";
b) group "0".

Expected result

a) User is added to user group titled "2".
b) User is added to user group titled "0".

Actual result

a) User is added to user group titled "2" but also removed from user group with ID 2 ("Registered").
b) "Access Usergroup Invalid" error.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 5 Apr 2018
avatar SharkyKZ SharkyKZ - change - 5 Apr 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Apr 2018
Category ⇒ Libraries
avatar SharkyKZ SharkyKZ - change - 5 Apr 2018
The description was changed
avatar SharkyKZ SharkyKZ - edited - 5 Apr 2018
avatar SharkyKZ SharkyKZ - change - 5 Apr 2018
Title
…
Fix for JUserHelper::addUserToGroup() when user group is a number.
Fix for JUserHelper::addUserToGroup() when user group title is a number.
avatar SharkyKZ SharkyKZ - edited - 5 Apr 2018
avatar Quy
Quy - comment - 5 Apr 2018

The title column is no longer applicable. Should the comment be removed and change select to ->select('id')?

			// Get the title of the group.
			$db = \JFactory::getDbo();
			$query = $db->getQuery(true)
				->select($db->quoteName('title'))
avatar SharkyKZ SharkyKZ - change - 6 Apr 2018
Labels Added: ?
avatar SharkyKZ
SharkyKZ - comment - 6 Apr 2018

The result would be the same but I guess it is cleaner.

avatar Quy
Quy - comment - 6 Apr 2018

I have tested this item ✅ successfully on 5a747b5

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20091.

avatar Quy Quy - test_item - 6 Apr 2018 - Tested successfully
avatar tpelek
tpelek - comment - 10 Apr 2018

I have tested this item ✅ successfully on 5a747b5

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20091.

avatar tpelek tpelek - test_item - 10 Apr 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 10 Apr 2018
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Apr 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 22 Apr 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-04-22 15:41:20
Closed_By ⇒ mbabker
Labels Added: ?
avatar mbabker mbabker - close - 22 Apr 2018
avatar mbabker mbabker - merge - 22 Apr 2018

Add a Comment

Login with GitHub to post a comment