[#20080] - Remove rtrim() since it allows invalid emails
- Fixed in Code Base
- 7 Apr 2018
- Medium
- Build: staging
- # 20080
- Diff
- OctavianC:patch-11
User tests: Successful: Unsuccessful:
Pull Request for Issue #20075 .
Summary of Changes
JMailHelper was right-trimming all dots in the domain part of an email address, so invalid emails such as test@joomla.org. were passing validation.
Testing Instructions
Testing instructions in #20075
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I'm just here for fixing this particular bug - there are other places where email validation takes place and maybe in the future there should be a single function?
https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Form/Rule/EmailRule.php
Afaik there's already filtering in place.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20080.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20080.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-07 14:30:49 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Should we not do some regex magic to filter out all characters which are not valid?