Feeling Lucky
?
?
[#20064] - [RFC] Fix editor instance always using the configuration of its 1st call
- Closed
- 24 Oct 2020
- Medium
- Build: staging
- # 20064
- Diff
- ggppdk:fix_editor_instance_ignoring_config_on_2nd_call
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for issues similar to #20062
Summary of Changes
The editor instance created by method
JEditor::_loadEditor($config);
will always ignore $config 2nd, 3rd, etc call
Are there any side-effects to this PR
Is there code depending on current bogus behaviour ?
Also this fix is propably incomplete,
because the new $config array will be set but any values existing in the old $config continue to be in use
Testing Instructions
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
brianteeman
- comment
- 24 Oct 2020
This should probably be closed as it was opened as an RFC 2.5 years ago
Quy
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-24 18:07:32 |
| Closed_By | ⇒ | Quy |
Hard to tell, but if every editor was using just the display function we wouldn't have this mess in the first place:
https://github.com/ggppdk/joomla-cms/blob/65540041e17e2a9ac3202428fd0647628d3f6a86/libraries/src/Editor/Editor.php#L290-L324