J3 Issue ?
avatar Septdir
Septdir
1 Apr 2018

I will not write a long introduction but just give examples
Please take a closer look at the timestamps

03:00 Automatic server backup
15:00 New user registered. Let's call it Mike
18:00 The administrator mistakenly deletes Mike

In this situation, it is almost impossible to restore the user.

Of course this is entirely the fault of the administrator.
You can prevent administrators from deleting users.
You can only delete them after you create a backup
But no one is immune from mistakes.

Therefore, I add state trash or confirm message.
It is clear that adding to the state is quite problematic, need change database table, rewrite the user's rights, etc.
However, just adding a popup / modal / confirm window with usernames to control panel template is quite simple.

Popup / Modal window will be preferable because they are better seen, unlike the standard confirm

avatar Septdir Septdir - open - 1 Apr 2018
avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 1 Apr 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Apr 2018
Category com_users
avatar brianteeman brianteeman - change - 3 Apr 2018
Labels Added: J3 Issue
avatar brianteeman brianteeman - labeled - 3 Apr 2018
avatar Quy
Quy - comment - 4 Apr 2018

I get an alert/warning before deletion:
Are you sure you want to delete? Confirming will permanently delete the selected item(s)!

avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Apr 2018
Status New Information Required
avatar Septdir
Septdir - comment - 4 Apr 2018

@Quy I also have this message, however, it does not specify who exactly you delete.
I change first message and title

P.S In truth, seeing such a message does not stop to think about action

avatar Septdir Septdir - change - 4 Apr 2018
The description was changed
avatar Septdir Septdir - edited - 4 Apr 2018
avatar Septdir Septdir - change - 4 Apr 2018
Title
[com_users] Add trash or confirm when delete user
[com_users] Add trash or change confirm when delete user
avatar Septdir Septdir - edited - 4 Apr 2018
avatar Septdir Septdir - change - 4 Apr 2018
The description was changed
avatar Septdir Septdir - edited - 4 Apr 2018
avatar tonypartridge
tonypartridge - comment - 6 Apr 2018

We can easily chuck in the user name with sprintf. But it’s not really soling the issue you had.

I suppose you could add a trash system but this is quite a lot of work for users given it’s usage.

avatar tonypartridge
tonypartridge - comment - 6 Apr 2018

I’d probably recommend you re-train your admins not to delete users and instead to block them and purge ones without activity that are blocked after x months.

avatar Quy
Quy - comment - 6 Apr 2018

Take it one step further to hide the Delete button with css and unhide when ready to delete.

avatar Septdir
Septdir - comment - 6 Apr 2018

@Quy Well, on their sites I'll figure out how to be. But I think that this problem happens not only for me

avatar tonypartridge
tonypartridge - comment - 6 Apr 2018

I see your point, I think the warning could be bigger and more prominent.

But fundamentally it’s a training issue.

With GDPR coming in, trashing users for instance will be even more frowned upon since when you want to delete a user they should be deleted.

On 6 Apr 2018, 16:01 +0100, Igor Berdichevskiy notifications@github.com, wrote:

@Quy Well, on their sites I'll figure out how to be. But I think that this problem happens not only for me

You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar Septdir
Septdir - comment - 6 Apr 2018

@tonypartridge You are undoubtedly right that people need to be trained and trained, but this is not stahovka from mistakes. For example, do you delete several users, how to check before deleting?

With GDPR coming in, trashing users for instance will be even more frowned upon since when you want to delete a user they should be deleted.

In com_content, com_categories, com_menu .. have trashed in com_users permanent delete.
Long time working with content a person gets used to the fact that he can always be restored from trashed and often does not think about the fact that in com_users permanent delete.

Hmm .. can be allowed to delete only blocked I guess I'll do it on my site

avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Apr 2018
Status Information Required Discussion
avatar Septdir
Septdir - comment - 10 Apr 2018

On my sites I did so

  • IF filter.state != 1 Remove users.delete & users.unblock ELSE remove users.block
  • IF filter.active!= 1 Remove users.activate

Maybe later I'll correct model to change the query to the database

avatar Septdir
Septdir - comment - 11 Apr 2018

If such an idea with buttons is interesting then I can do PR on next week

avatar Quy
Quy - comment - 11 May 2018

@Septdir Please submit a PR. Thanks.

avatar Septdir
Septdir - comment - 11 May 2018

@Quy done

avatar Quy Quy - change - 11 May 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-05-11 23:15:47
Closed_By Quy
avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2018
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 11 May 2018
avatar joomla-cms-bot
joomla-cms-bot - comment - 11 May 2018

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/20049

avatar Quy
Quy - comment - 11 May 2018

See PR #20348


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20049.

Add a Comment

Login with GitHub to post a comment