[#20043] - Fix GMail plugin so it doesn't crash and burn on 4.0 upgrades
- Fixed in Code Base
- 3 Apr 2018
- Medium
- Build: staging
- # 20043
- Diff
- mbabker:fix-gmail-error-handling
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Since it was elected to remove this plugin from the 4.0 distro, the 3.x version of the plugin needs to be maintained well enough so that when sites upgrade to 4.0 they don't fatally error out because the plugin is enabled. This PR fixes the one issue point.
When the HTTP layer throws an Exception, the plugin is currently creating a stubbed Response object which gets processed in the code immediately following the request. In 4.0, the Response object won't be writable through the old class member variables so this mocking won't work correctly anymore. Instead, as is done in other try/catch blocks, the authentication response should just be set as a failure and returned.
Testing Instructions
Code review
Expected result
GMail plugin can be migrated to 4.0 and continue functioning
Actual result
Error handling in the plugin will not work in 4.0
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
shouldnt have been removed.
I'm just here to prevent PR nightmares that are preventable, I've been politics free for 6 days and would prefer that to reach 7
laoneo
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-03 05:58:19 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
It won't be maintained "well enough" without a dedicate repo etc.shouldnt have been removed.