Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#20041] - [#18721] - [4.0] Editing module on frontend causes 500 on ordering ajax

Pending

User tests: Successful: Unsuccessful:

avatar amone4
amone4
31 Mar 2018

Modified the code related to module ordering, in the module dispatcher

Pull Request for Issue #18721 .

Summary of Changes

The value of task was wrongly identified. Also, the client was changed from site to administrator, to invoke the controller present on the administrator's side

Testing Instructions

Edit a module on the frontend

Expected result

No errors with a select field in front of 'ordering' option

Actual result

Same as expected

Documentation Changes Required

None

avatar amone4 amone4 - open - 31 Mar 2018
avatar amone4 amone4 - change - 31 Mar 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Mar 2018
Category ⇒ Front End com_modules
avatar laoneo
laoneo - comment - 3 Apr 2018

Can you save the module with the latest code from 4.0-dev branch? I can't
image

@dgt41 any clue?

avatar laoneo
laoneo - comment - 3 Apr 2018

@amone4 did you delete your repo?

avatar dgt41
dgt41 - comment - 3 Apr 2018

Just add a class validate to the form and that should solve it

avatar amone4
amone4 - comment - 3 Apr 2018

@laoneo I checked my Joomla 4 version, and it is up to date
git

After doing the above modifications, I tried clicking save without making any changes
I didn't really experience the issue you're talking about, but a totally different one

error

avatar Anu1601CS
Anu1601CS - comment - 3 Apr 2018

@amone4 I think you did your changes in 4.0-dev branch and done the PR.
Then, deleted the repo and re-forked repo done the next PR right!

avatar Anu1601CS
Anu1601CS - comment - 3 Apr 2018

If Yes, This is not a right process. I saw your all other PR have the same problem.

avatar amone4
amone4 - comment - 3 Apr 2018

@Anu1601CS Not exactly. But yes, after the last PR, I had to delete my repo. Sorry! Didn't know that it would cause a problem. Should I make the PR again?

avatar Anu1601CS
Anu1601CS - comment - 3 Apr 2018

@amone4

Should I make the PR again?
Yes

For a tip always create a new branch for new PR. Don't use the main branch.
No, need to delete repo and re-fork repo.

avatar amone4
amone4 - comment - 5 Apr 2018

@Anu1601CS Thanks. I've made a new PR #20088

avatar Quy Quy - change - 5 Apr 2018
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-04-05 20:13:58
Closed_By ⇒ Quy
avatar joomla-cms-bot joomla-cms-bot - change - 5 Apr 2018
Closed_Date 2018-04-05 20:13:58 ⇒ 2018-04-05 20:13:59
Closed_By Quy ⇒ joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 5 Apr 2018
avatar joomla-cms-bot
joomla-cms-bot - comment - 5 Apr 2018

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/20041

Add a Comment

Login with GitHub to post a comment