User tests: Successful: Unsuccessful:
Pull Request for Issue #19518
Adding fulltext to the introtext to highlight the found term
Create an article with a readmore.
Add some text after the readmore: I used here elegant
Use smartsearch in frontend and search for elegant
Term highlighted.
Term not highlighted.
None
Status | New | ⇒ | Pending |
Category | ⇒ | Front End com_finder |
not sure i understand. description is in fact summary.
introtext is summary and body is fulltext
Here is from the Joomla! Testing
article where the bulleted list is missing the beginning markup <ul>
.
<p class="result-text">
of rendering--items not aligned correctly, missing or wrong images, pages that just don't look right.</li>
<li>Unexpected behavior--anything that is working differently than it did in 2.5.</li>
</ul>
<p>Report problems</p>
<p>If you find a problem</p>... </p>
<div class="small result-url">
http://localhost/joomla-cms-staging/index.php </div>
</li>
</ul>
<br id="highlighter-end" />
Add var_dump($this->result); exit;
above // Make sure we highlight term both in introtext and fulltext
to see the values for summary
, body
, and description
. Only description
is text where the summary
and body
are HTML.
Labels |
Added:
?
|
@Quy
Understood now. Thanks.
Corrected patch.
To test, first make sure you added a readmore in that same article.
Then add a var_dump($full_description); exit;
before // Find the position of the search term
Search a term which is placed after the readmore.
we now get text only.
In the screenshot below the first article has a readmore, the second one not.
I have tested this item
@Ooops-404
please test
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-01 15:32:04 |
Closed_By | ⇒ | mbabker | |
Labels |
Added:
?
|
It is possible to output invalid markup when truncated since
summary
andbody
are HTML.description
is text so not an issue.