? ? ? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
28 Mar 2018

Summary of Changes

This PR removes some params displayed in the form but not used in the code.

Testing Instructions

Code review.

Documentation Changes Required

Help article needs updating https://help.joomla.org/proxy?keyref=Help38:Menus_Menu_Item_Finder_Search&lang=en#Advanced_Options

avatar SharkyKZ SharkyKZ - open - 28 Mar 2018
avatar SharkyKZ SharkyKZ - change - 28 Mar 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Mar 2018
Category Administration Language & Strings Front End com_finder SQL Installation Postgresql MS SQL Unit Tests
avatar SharkyKZ SharkyKZ - change - 28 Mar 2018
The description was changed
avatar SharkyKZ SharkyKZ - edited - 28 Mar 2018
avatar jcata
jcata - comment - 28 Mar 2018

Hi guys, I've tested this patch and is ok


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20009.

avatar Quy
Quy - comment - 28 Mar 2018

@jcata Please do the following to mark your test as successful:

  • Open Issue Tracker
  • Log in with your Github account
  • Click on blue Test this button above author's photo
  • Select Tested successfully
  • Click Submit test result
avatar jcata
jcata - comment - 28 Mar 2018

I have tested this item successfully on 5040a04

Hi guys, I've tested this patch and is ok


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20009.

avatar jcata jcata - test_item - 28 Mar 2018 - Tested successfully
avatar brianteeman
brianteeman - comment - 28 Mar 2018

The usual rule is that language strings are not removed as they might be used elsewhere. They can be marked as deprecated

avatar SharkyKZ SharkyKZ - change - 29 Mar 2018
Labels Added: ? ? ?
avatar SharkyKZ
SharkyKZ - comment - 29 Mar 2018

Strings restored and marked for deprecation.

avatar Quy
Quy - comment - 29 Mar 2018

I have tested this item successfully on 841cec1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20009.

avatar Quy Quy - test_item - 29 Mar 2018 - Tested successfully
avatar Quy Quy - alter_testresult - 29 Mar 2018 - jcata : Tested successfully
avatar Quy Quy - change - 29 Mar 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 29 Mar 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20009.

avatar jcata
jcata - comment - 31 Mar 2018

I have tested this item successfully on 841cec1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20009.

avatar jcata jcata - test_item - 31 Mar 2018 - Tested successfully
avatar mbabker mbabker - change - 1 Apr 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-04-01 15:30:24
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 1 Apr 2018
avatar mbabker mbabker - merge - 1 Apr 2018

Add a Comment

Login with GitHub to post a comment