? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
26 Mar 2018

Summary of Changes

An argument is passed, but the language string is missing a placeholder

$subject_default = JText::sprintf('COM_MAILTO_SENT_BY', $sender);

COM_MAILTO_SENT_BY="Item sent by"

Testing Instructions

Code review

Documentation Changes Required

none

avatar Quy Quy - open - 26 Mar 2018
avatar Quy Quy - change - 26 Mar 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Mar 2018
Category Language & Strings
avatar Quy Quy - change - 26 Mar 2018
The description was changed
avatar Quy Quy - edited - 26 Mar 2018
avatar infograf768
infograf768 - comment - 27 Mar 2018

I have tested this item successfully on 618098a

OK on review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19999.

avatar infograf768 infograf768 - test_item - 27 Mar 2018 - Tested successfully
avatar ggppdk
ggppdk - comment - 27 Mar 2018

I have tested this item successfully on 618098a

I have applied patch
#19956

then also applied the language string change of this PR
the default subject is now correctly created

Item sent by SomeSender


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19999.

avatar ggppdk ggppdk - test_item - 27 Mar 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 27 Mar 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 27 Mar 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 29 Mar 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-03-29 11:53:32
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 29 Mar 2018
avatar mbabker mbabker - merge - 29 Mar 2018

Add a Comment

Login with GitHub to post a comment