? ? ? ? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
25 Mar 2018

Pull Request for Issue #19940

Summary of Changes

Add session storage backend supporting PHP's ext/apcu

Testing Instructions

Install patch, on a platform where APCu is installed and enabled try to use APCu as a session storage backend

avatar mbabker mbabker - open - 25 Mar 2018
avatar mbabker mbabker - change - 25 Mar 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Mar 2018
Category ⇒ Administration Language & Strings Libraries Unit Tests
avatar zero-24
zero-24 - comment - 29 Mar 2018

@f-hamel can you please test the patch provided by @mbabker ?

If you need help with that feel free to ask questions. As I personally don't have a server with APCu enabled.

You can find a documentations how you can test here in detail: https://docs.joomla.org/Testing_Joomla!_patches

The easiest way would be to download & install the latest nigthly build for Joomla 3.9:
https://developer.joomla.org/nightlies/Joomla_3.9.0-dev-Development-Full_Package.zip
Install the com_patchtester component:
https://github.com/joomla-extensions/patchtester/releases/tag/2.0.1
Refresh the data.
use the search bar to get to the PR ID: 19990 & hit apply patch.
Than you can try to use apcu as session storage as requested in your issue.
Please report any questions / issues or suggestions to this page so this can be discussed & adressed.

Please note that this only can get merged into the core & released if we have tests on this code proposal. Thanks ?

avatar f-hamel
f-hamel - comment - 29 Mar 2018

@zero-24 and @mbabker I'm sorry. I was little bit busy the last days.
So thanks for remembering and this good testing instruction.
I could apply the patch and test.

There was no unexpected behavior.
APCu Session storage is available and works fine.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Mar 2018

@f-hamel please mark your Test as successfully:

  • open Issue Tracker
  • Login with your github-Account
  • Click on blue "Test this"-Button above Authors-Picture
  • mark your Test as successfully
  • hit "submit test result"
avatar f-hamel
f-hamel - comment - 29 Mar 2018

I have tested this item ✅ successfully on 68924ca


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19990.

avatar f-hamel f-hamel - test_item - 29 Mar 2018 - Tested successfully
avatar zero-24
zero-24 - comment - 30 Mar 2018

@mbabker can you update that branch to 3.9-dev so we keep drone happy.

I would like to move this RTC than given that the code bases on the framework and @f-hamel 's test on a live environment.

avatar zero-24 zero-24 - change - 30 Mar 2018
Labels Added: ? ? ?
avatar zero-24
zero-24 - comment - 30 Mar 2018

Ah they just enabled the push button :)

avatar zero-24 zero-24 - change - 30 Mar 2018
Status Pending ⇒ Ready to Commit
Labels
avatar zero-24
zero-24 - comment - 30 Mar 2018

RTC. Thanks ?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19990.

avatar laoneo
laoneo - comment - 31 Mar 2018

Is this valid for 4.0 too? Or do we have there APCU from the framework package?

avatar mbabker
mbabker - comment - 31 Mar 2018

APCu is already in the Framework package.

On Sat, Mar 31, 2018 at 1:23 PM Allon Moritz notifications@github.com
wrote:

Is this valid for 4.0 too? Or do we have there APCU from the framework
package?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#19990 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoTkhMTrp0J8RXnybJrg4jK-Xkzcqks5tj8mygaJpZM4S6Qzk
.

--

  • Michael Please pardon any errors, this message was sent from my iPhone.
avatar mbabker
mbabker - comment - 12 May 2018

Cherry picked into 3.9 via 51dc6e0

avatar mbabker mbabker - close - 12 May 2018
avatar mbabker mbabker - change - 12 May 2018
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-05-12 17:18:38
Closed_By ⇒ mbabker
Labels Added: ? ?
Removed: ?

Add a Comment

Login with GitHub to post a comment