[#19985] - [3.x] com_wrapper. Add HTML5 mode without B\C break.
- Closed
- 4 Apr 2018
- Medium
- Build: staging
- # 19985
- Diff
- ReLater:patch-7
User tests: Successful: Unsuccessful:
Related to #19965
See discussion there concerning B\C breaks in Joomla 3.x.
@BaleshSrle
Please feel free to take over code and/or idea into your pr. I have no problems to close this one then.
Summary of Changes
- Adds a new switch
Legacy (HTML4)versusHTML5. Legacyis the default setting. Thus, this pr will not break older template overrides that use HTML4 attributes for IFRAME tags that have been removed in HTML5.- Doesn't touch old parameter types and names but translates them via PHP for
HTML5mode if necessary. HTML5uses CSS style instead.- Comment: Because most current browsers don't support CSS rule
overflowfor displaying/hiding scroll barsscrollingattribute cannot be removed in HTML5 mode.
Testing Instructions
- Apply patch.
- Create a menu item of type "Wrapper" with setting
Mode = Legacy. - Create another menu item of type "Wrapper" with setting
Mode = HTML5.
- Compare outputs in frontend.
- Test other settings and compare output in frontend.
- As far as I see: Old template overrides should still work even if you switch mode to
HTML5because only default.php of core respects new setting.
Expected result
- No optical difference
Documentation Changes Required
????
New language strings
YES
Please help to optimize description.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_wrapper |
| Labels |
Added:
?
|
||
| Category | Front End com_wrapper | ⇒ | Administration Language & Strings Front End com_wrapper |
| Labels |
Added:
?
|
||
You managed to work all major kinks, but there is an issue with scrolling (in HTML4) or overflow (in HTML5) in components/com_wrapper/views/wrapper/tmpl/default.xml
More about this you can see @ https://www.w3schools.com/cssref/pr_pos_overflow.asp (auto, scroll & hidden are the main options).
In CS there is no need to have line $frameborder = !$frameborder ? 'none' : $frameborder . 'px solid #000';. I tried to add something similar (in default.php and default.xml), but after uploading that file and refreshing my web site, I discovered an error and I left values 1 and 0 in frameborder field (and I can inform you that works).
border: none; is correct and valid CSS. So I don't see any problems to use it.
border: 1; is invalid CSS. If you see an iframe border in your browser the reason is that the browser that you use ignores this invalid setting and falls back to it's own default CSS rules (if there are no other overruling ones in other CSS files). (EdIT: Or your browser is a nice one ;-) )
Only border: 1px; doesn't show a frameborder in current Joomla staging and that's the criterion for this pr. "Be B\C".
So use border: 1px solid #000; to display a border like with frameborder="1" in Legacy mode.
border: 1px; (HTML 5)
border: 1px solid #000; (HTML 5)
frameborder="1" (Legacy)
(auto, scroll & hidden are the main options).
And these three overflow values are used in HTML5 mode and ONLY in HTML5 mode. So, I don't understand what you're talking about.
In Legacy mode nothing has changed an scrolling is yes|no|auto like before.
I'm closing here until I've found a solution for Scroll Bars in HTML5 mode.
It looks like most browsers don't support CSS rule overflow for tag IFRAME.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-25 21:25:23 |
| Closed_By | ⇒ | ReLater |
| Status | Closed | ⇒ | New |
| Closed_Date | 2018-03-25 21:25:23 | ⇒ | |
| Closed_By | ReLater | ⇒ |
| Status | New | ⇒ | Pending |
Reopened after additional commit.
I had to add a fallback for setting Scroll Bars .
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-04 17:19:44 |
| Closed_By | ⇒ | ReLater |
I have tested this item✅ successfully on 47a52d6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19985.