Feeling Lucky
?
?
[#19979] - Change to allow str_pos to match when the exclude term is at the root…
- Fixed in Code Base
- 25 Mar 2018
- Medium
- Build: staging
- # 19979
- Diff
- tonypartridge:staging-redirect-exclude-fx
User tests: Successful: Unsuccessful:
… of the path
Pull Request for Issue #19973 .
Summary of Changes
add a space beginning of the heystack,
str_pos seems to fail when begining with a / in the heystack so begin with a space followed by a /
Testing Instructions
Add:
/bogus/
to a url in your site, it should 404.
Now delete the 404, add /bogus/ to the exclusion list
Access the /bogus/ url again.
Expected result
404 and not add to the com_redirects
Actual result
404 and adds to the com_redirects.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
ReLater
- comment
- 25 Mar 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19979.
ggppdk
- comment
- 25 Mar 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19979.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 25 Mar 2018
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19979.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-25 15:01:13 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
So the bug occurs when exclusion text is found at the very first position of the URL
that is when exclusion text is found at position 0 (zero), so existing check fails for this reason, because it considers zero return value .... as not found
@tonypartridge
you latest commit looks good, but can you also update "Summary of Changes" to explain the change, and describe why this bug occurs