? ? Pending

User tests: Successful: Unsuccessful:

avatar tonypartridge
tonypartridge
24 Mar 2018

Pull Request for Issue #14734.

Summary of Changes

Changing - None Selected - to - None -
So this now caters when there are no plugins/options to select.

Testing Instructions

Disable all recaptcha plugins, edit global config

Expected result

None is displayed so at a view you can see you haven't enabled any without additional clicks.
Also readonly since none are able to be selected

Actual result

Says - None Selected - which indicates there is one which can be selected.

avatar tonypartridge tonypartridge - open - 24 Mar 2018
avatar tonypartridge tonypartridge - change - 24 Mar 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Mar 2018
Category Administration Language & Strings Libraries
avatar tonypartridge tonypartridge - change - 24 Mar 2018
Labels Added: ? ?
avatar ggppdk
ggppdk - comment - 24 Mar 2018

I have tested this item successfully on 0dbff98


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19977.

avatar ggppdk ggppdk - test_item - 24 Mar 2018 - Tested successfully
avatar tonypartridge
tonypartridge - comment - 24 Mar 2018

Thanks!

On 24 Mar 2018, 23:04 +0000, Georgios Papadakis notifications@github.com, wrote:

I have tested this item successfully on 0dbff98
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19977.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar Quy
Quy - comment - 25 Mar 2018

So when there is a plugin enabled, should it be - None Selected -?

avatar tonypartridge
tonypartridge - comment - 25 Mar 2018

Ideally, but given the usage case I couldn’t see an easy way without BC Breaks to implement that when not readOnly. So a wildcard none should be sufficient for both scenarios.

On 25 Mar 2018, 18:48 +0100, Quy notifications@github.com, wrote:

So when there is a plugin enabled, should it be - None Selected -?

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar Quy
Quy - comment - 25 Mar 2018

or keep the language string as it and only disable the dropdown when no plugins available?

avatar tonypartridge
tonypartridge - comment - 25 Mar 2018

I did think about that, if you think that’s better I’ll change it :-)

On 25 Mar 2018, 20:37 +0100, Quy notifications@github.com, wrote:

or keep the language string as it and only disable the dropdown when no plugins available?

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Mar 2018
Category Administration Language & Strings Libraries Language & Strings Libraries
avatar joomla-cms-bot joomla-cms-bot - change - 27 Mar 2018
Category Language & Strings Libraries Libraries
avatar tonypartridge tonypartridge - change - 27 Mar 2018
Labels Removed: ?
avatar tonypartridge
tonypartridge - comment - 27 Mar 2018

I've updted it @Quy as you are right since we are disabling the selection that's valid enough.

avatar Quy
Quy - comment - 28 Mar 2018

I have tested this item successfully on a86a205


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19977.

avatar Quy Quy - test_item - 28 Mar 2018 - Tested successfully
avatar Quy
Quy - comment - 28 Mar 2018

I have tested this item successfully on 2e87f79


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19977.

avatar Quy Quy - test_item - 28 Mar 2018 - Tested successfully
avatar Quy
Quy - comment - 2 Apr 2018

The asterisks should align.

/**
 * 
 * 
 * 
 */
avatar tonypartridge
tonypartridge - comment - 5 Apr 2018

@Quy it’s done, can go to RTC now

avatar Quy
Quy - comment - 5 Apr 2018

I have tested this item successfully on b82fdbb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19977.

avatar Quy Quy - test_item - 5 Apr 2018 - Tested successfully
avatar Quy Quy - change - 5 Apr 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 5 Apr 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19977.

avatar mbabker mbabker - change - 7 Apr 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-04-07 14:35:59
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 7 Apr 2018
avatar mbabker mbabker - merge - 7 Apr 2018

Add a Comment

Login with GitHub to post a comment