[#19977] - Changed none selected to none, to be used when there are none availab…
- Fixed in Code Base
- 7 Apr 2018
- Medium
- Build: staging
- # 19977
- Diff
- tonypartridge:staging-default-none-select
User tests: Successful: Unsuccessful:
Pull Request for Issue #14734.
Summary of Changes
Changing - None Selected - to - None -
So this now caters when there are no plugins/options to select.
Testing Instructions
Disable all recaptcha plugins, edit global config
Expected result
None is displayed so at a view you can see you haven't enabled any without additional clicks.
Also readonly since none are able to be selected
Actual result
Says - None Selected - which indicates there is one which can be selected.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Libraries |
| Labels |
Added:
?
?
|
||
Thanks!
On 24 Mar 2018, 23:04 +0000, Georgios Papadakis notifications@github.com, wrote:
I have tested this item
✅ successfully on 0dbff98
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19977.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
So when there is a plugin enabled, should it be - None Selected -?
Ideally, but given the usage case I couldn’t see an easy way without BC Breaks to implement that when not readOnly. So a wildcard none should be sufficient for both scenarios.
On 25 Mar 2018, 18:48 +0100, Quy notifications@github.com, wrote:
So when there is a plugin enabled, should it be - None Selected -?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
or keep the language string as it and only disable the dropdown when no plugins available?
I did think about that, if you think that’s better I’ll change it :-)
On 25 Mar 2018, 20:37 +0100, Quy notifications@github.com, wrote:
or keep the language string as it and only disable the dropdown when no plugins available?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
| Category | Administration Language & Strings Libraries | ⇒ | Language & Strings Libraries |
| Category | Language & Strings Libraries | ⇒ | Libraries |
| Labels |
Removed:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19977.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19977.
The asterisks should align.
/**
*
*
*
*/
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19977.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19977.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-07 14:35:59 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 0dbff98
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19977.