? Pending

User tests: Successful: Unsuccessful:

avatar minhSDD
minhSDD
23 Mar 2018

Pull Request for Issue # .19227
Summary of Changes

Make Password Strength Bar Width equal to above input box
Testing Instructions

1/ Go to administrator/index.php?option=com_users
2/ Click New
3/ Enter a password
Expected result

Password Strength Bar Width is equal to above input box. This make nicer look.

avatar minhSDD minhSDD - open - 23 Mar 2018
avatar minhSDD minhSDD - change - 23 Mar 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Mar 2018
Category Administration Templates (admin)
avatar zero-24 zero-24 - change - 23 Mar 2018
Title
fix issue 19227
Fix for [4.0] Password Strength Bar Width is 100%.
avatar zero-24 zero-24 - edited - 23 Mar 2018
avatar dgt41
dgt41 - comment - 23 Mar 2018

Please do your PR against #19231

avatar zero-24
zero-24 - comment - 23 Mar 2018

@dgt41 please update that PR first as this looks very out of date ;)

avatar minhSDD minhSDD - change - 23 Mar 2018
Labels Added: ?
avatar minhSDD minhSDD - change - 23 Mar 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-03-23 18:26:13
Closed_By minhSDD
avatar minhSDD minhSDD - close - 23 Mar 2018
avatar minhSDD
minhSDD - comment - 23 Mar 2018

( sorry for my test )
Try to reopen to see what's happen

avatar minhSDD minhSDD - change - 23 Mar 2018
Status Closed New
Closed_Date 2018-03-23 18:26:13
Closed_By minhSDD
avatar minhSDD minhSDD - change - 23 Mar 2018
Status New Pending
avatar minhSDD minhSDD - reopen - 23 Mar 2018
avatar dgt41
dgt41 - comment - 23 Mar 2018

@zero-24 done!

@minhSDD actually this is already patched in #19231 but there are still some todos in that PR if you want to patch something!

screen shot 2018-03-23 at 19 35 18
screen shot 2018-03-23 at 19 38 10

avatar minhSDD
minhSDD - comment - 23 Mar 2018

@dgt41 : To start my work for your RP, I should run
git checkout origin dgt41:fields/password
Is it right ?

avatar dgt41
dgt41 - comment - 23 Mar 2018

yup

avatar minhSDD
minhSDD - comment - 23 Mar 2018

@dgt41 :
Please tell me the detail of job. I saw:
-Still Bootstrap specific
-Still Font awesome specific
-Needs A11Y audit
-Needs final approval form the design team
Then what exactly we should do ?

avatar dgt41
dgt41 - comment - 24 Mar 2018

Here is a more detailed explanation of the todos:

  • Remove bootstrap specific code:
    Actions needed: rename the classes to not conflict with bootstrap (or better use some scss with specificity starting at the element joomla-field-password).
  • Remove Font awesome dependency:
    Create a scss file (check https://github.com/joomla/joomla-cms/blob/4.0-dev/build/webcomponents/scss/field-switcher/field-switcher.scss as a reference) and remove the fa fa-eye classes and use the svg instead.
  • A11Y: I'm not an accessibility expert but I guess the first parent span, that in reality is a button, needs to be renamed to button tag. Also make sure the the click and keyboard events work correctly. There might be other issues with the progress bar and the extra notification, but that needs to be audited by someone like @zwiastunsw

PS: just for reference you need to have node and npm installed.
You need to run npm install at the project's root folder

To recompile the elements you need to run:
for the scss to css:
node build.js --compilecescss
for the js:
node build.js --compilecejs

avatar minhSDD
minhSDD - comment - 24 Mar 2018

@dgt41 Thanks for your point.
I can take a look at "Remove bootstrap specific" and "Remove Font awesome".
I will update when it's ready.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19971.

avatar C-Lodder
C-Lodder - comment - 24 Mar 2018

Please dont just add your code to the SCSS and CSS files like you have. They need to be in the correct files and compiled properly.

avatar minhSDD
minhSDD - comment - 24 Mar 2018

@C-Lodder Please clear me:
I understand follow steps:
1/ edit scss file
2/ compile scss to css file
3/ minimized css to min.css
4/ .. commit scss, css, min.css to branch
pls point me the correct files and proper way to commit.
Thank you

avatar C-Lodder
C-Lodder - comment - 24 Mar 2018

@minhSDD The is an open PR to convert this field to a custom element: #19231 by @dgt41

You'll need to add your code to the SCSS files in that PR and have them compiled against his PR.

avatar minhSDD
minhSDD - comment - 25 Mar 2018

@dgt41 Hi, pls guide me:
I already fork Joomla-cms from Joomla.
As to my understand, I have to fork your repository Joomla-cms, to see branch fields/password.
If I try to fork your repository Joomla-cms, it's always point to Joomla repository.
What should I do here ? Thank you

avatar laoneo
laoneo - comment - 11 Apr 2018

You can't fork the same repo twice in your account.

avatar Quy Quy - change - 20 May 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-05-20 02:35:39
Closed_By Quy
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2018
Closed_Date 2018-05-20 02:35:39 2018-05-20 02:35:40
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot
joomla-cms-bot - comment - 20 May 2018

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/19971

avatar joomla-cms-bot joomla-cms-bot - close - 20 May 2018
avatar Quy
Quy - comment - 20 May 2018

Fixed in PR #19231


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19971.

Add a Comment

Login with GitHub to post a comment