For image fields, PDFs should not be displayed/selectable.

With the PR, the PDF is selectable, but won't display on the frontend to be clickable.

<div class="pull-left item-image"> <img
			 src="/joomla-cms-staging/images/test.pdf" alt="" itemprop="image"/> </div>

For image fields, PDFs should not be displayed/selectable.
With the PR, the PDF is selectable, but won't display on the frontend to be clickable.

Yes non-images should not be selectable in the image fields

Using the image fields (of images and links TAB)
is just an easy example that this PR works

The selection for non-images for specific cases should be disallowed
but before i would add anything more i would like to see if there is interest in this PR and suggestions on how to limit the view

In my own views i am using ACL + a configuration id that corresponds to the configuration data in the DB to decide what is shown / not shown, and also do other customization on the view

Can you do this feature against the Joomla 4 branch? Don't want to introduce a new feature in J3 which doesn't exist in 4, better to do it the other way around. Thanks!

Hi, improvement this is really useful! I was diverted here after raising a change request #20057 but I'm not sure if the functionality is the same. Would you mind comparing the text of that issue?

In particular, can I just check if this change provides access to all types of media? I recently developed a website with media which included .gpx files (XML format files of GPS tracks), so would those be visible for example?

Also, I suggested being able to filter on the types of media shown – eg by MIME type or file extension.

Many thanks!

@laoneo

Can you do this feature against the Joomla 4 branch? Don't want to introduce a new feature in J3 which doesn't exist in 4, better to do it the other way around. Thanks!

this PR so far only adds the listing of doc / video files without any configuration
(the above is done as long as legal extensions / MIME are added to com_media configuration)
and this is already possible in J4

so you mean
implement configuration of which files should be allowed per instance of media field as a PR to 4.0-dev branch and close this one ? (this has not been added to this PR --yet--)

@robbiejackson

you do not need wait for this PR to do it in any J3 installation

you can do it today, just add 2 lines

$docs    = $this->get('documents');
$videos  = $this->get('videos');

to your Joomla template override of
administrator/components/com_media/views/imageslist/tmpl/default.php
as
templates/JTEMPLATENAME/html/com_media/imageslist/default.php
administrator/templates/JTEMPLATENAME/html/com_media/imageslist/default.php

**and then add 2 loops in it **
1 loop to list documents and 1 loop to list videos

copy code for the 2 loops from here and correct the variable name of each loop
https://github.com/joomla/joomla-cms/pull/19967/files#diff-fac76ead6ee179d0a6802a886ffd84b2
https://github.com/joomla/joomla-cms/pull/19967/files#diff-64721eb2e5a153801fced8b9bae84016

if you need more help to do the above then please ask in Joomla forums or in PHP programming forums

[EDIT]
of course add the
add additional legal extensions/mime types into com_media configuration

@ggppdk
many thanks, I'll look into that,
Robbie

Escape filename like in #20616

Do you think this PR will merge soon ?

@Max00 every PR need 2 successfully Test, before a Maintainer decide to merge or not.

So if you wan't to help, please test.

@ggppdk will be good, now you add this great feature, the xtd-image button can do the same. Where the button put a link to the PDF (in case user select a PDF) or the <video></video> tag in case user select an .mp4 file.

@ggppdk
Would your PR solve #20969 ?

@infograf768

yes, but still this PR does not solve (yet) the configuration issue

You see there is the topic of how the MVC will decide that browsing docs and videos is allowed

Always showing all files

• is not an option at all, since you will be listing all media files when someone only wants to view and select images

Using (-only-) a parameter in url

• is not the way,since all existing websites after a joomla update, will suddenly allow this,

and someone by just by adding a parameter to the URL will be able to browse docs and videos in the media folder, before someone would need to know the filename for accessing a file

i suggest that the XTD button proposed in #20969
should have configuration in it

• doc folder root for browsing doc files, which file extensions to list, etc and user-group(s) (or access level needed) for browsing

then you would add to the mediaelements URL
&conf_ext=editor_xtd&ext_id=NN

then you would read configuration from the plugin
and display will happen according to the configuration in the plugin and according to the access level (or user-groups) of current user

@ggppdk we can test this PR, or you need still work in something more? I ask because of this:

but still this PR does not solve (yet) the configuration issue

So far, this PR only add the necessary layout for add that type of files, and if is all this PR will do, then we can test it, for see if we can have merged it. After that, we can use part of this code, in the xtd button feature

Thanks anyone spending time on this PR
No interest in spending more on it by me

@ggppdk Thank you so much for your code. I was able to use it completely as an override, without having to modify core-files.
That solved my problem with the media-manager in a modal-overlay (when using it as a field-type "media") and still my joomla can be updated :-)

@Robdebert your Comment on #19954 is resolve by your above?

@Robdebert would you mind sharing your override? Maybe as a gist? That would be great!

@level420 and @ghost: Sorry for the late reply.

I created a new issue, becuase i still think, that the media-fieldtype should use the same extensions as com_media allows, when editing the component-parameters. See #30548

Would be great, if you could support this new ticket, because the issue with the media-field is very old (i found a forum post from 2016 also).. and still Joomla-Core does not provide a modal-window fieldtype with the possibility to upload other files then images.