[#19924] - plg_search_content. content.xml. Adapt default values
- Fixed in Code Base
- 17 Mar 2018
- Medium
- Build: staging
- # 19924
- Diff
- ReLater:patch-4
User tests: Successful: Unsuccessful:
Testing Instructions: Code Review:
-
Have a look at installation file joomla.sql, line 586 https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L586
==>plg_search_contentis installed with default value1for parameterssearch_contentandsearch_archived -
Plugin file https://github.com/joomla/joomla-cms/blob/staging/plugins/search/content/content.php#L68-L69 uses default value
1, too. -
So, the default value for both parameters in manifest xml should be
1, too.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Title |
|
||||||
Have a look at installation file joomla.sql
Just a comment regarding this statement: The value in the SQL file doesn't have to match the default values used in XML and PHP files. We can set a default value in installations SQLs while having a different default value in XML/PHP for backward compatibility reasons.
Regardless this PR is fine because the default values in XML has to match the one in PHP.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19924.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-17 15:33:43 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on 7399d87
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19924.