[#19916] - Custom Admin menu item edit: Display Title, Parent Item and Ordering translations
- Fixed in Code Base
- 17 Mar 2018
- Medium
- Build: staging
- # 19916
- Diff
- infograf768:admin_menu_lang2
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Following up on #19900 (comment)
Summary of Changes
Adds a readonly fake field to display the translation of the Title when that one has been saved as a MOD_MENU_ variant after using the presets.
Translating the menu items concerned in the Ordering and Parent Item dropdowns
Testing Instructions
Same as #19900
Go to Menu Manager
Add a new Menu, type administrator, select one of the options predefined Joomla / predefined modern
Store the new menu.
Open the menu Manager and edit one of the menu items of this custom admin menu.
Before patch
Only the language constants are displayed.
After patch
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Language & Strings |
| Title |
|
||||||
| Labels |
Added:
?
?
|
||
If we really want to go into the detail, I would recommend this to go into joomla.edit.title_alias layout and wherever the title is all UPPERCASE and comprises of valid characters for a joomla language key, then we show this.
If we really want to go into the detail, I would recommend this to go into joomla.edit.title_alias layout and wherever the title is all UPPERCASE and comprises of valid characters for a joomla language key, then we show this.
That's no good and is similar to why I had to create #19802
If you have a menu item in capitals that matches a key it will be translated even if its just a conincidence
If we really want to go into the detail, I would recommend this to go into joomla.edit.title_alias layout and wherever the title is all UPPERCASE and comprises of valid characters for a joomla language key, then we show this.
The issue is only present in this special case i.e. for custom admin menus. Would'nt that be overkill?
Yes, my bad.
Shouldn't we hide this for New menu items?
Shouldn't we hide this for New menu items?
You mean by changing line 130 to something like
<?php if ($clientId === 1 && !empty($this->item->id)) : ?>
(Maybe !empty is not even necessary)
Yes $this->item->id == 0 should be fine.
Done
The vertical alignment of the Title label is lower than the value in the input field. See Link field to compare. The markup is not quite right.
Now the only issue that stays, is that we are limited to the language keys in mod_menu, com_menus. If we need to and can, we should think for a solution. Loading all languages are certainly NOT a solution
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19916.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19916.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Labels |
Added:
?
|
||
why to 3.9.0 ?
its a new feature not a bug fix
It is not really a hew feature. It helps users who are lost with these constants
Thanks
Although technically it is a feature, we've already merged minor feature additions to 3.8 that are bigger in scope than this (session metadata manager, update site mirrors). So, I'm OK with this one.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-17 15:39:03 |
| Closed_By | ⇒ | mbabker |
and they shouldnt have been
Not exactly in disagreement there, but the other option is every other release turns into a minor and we've already seen what kind of problems it causes when you add more minor releases and push merged things for a given minor branch back to another release. Sometimes you just have to make a gut call on what's best for everyone.
@izharaazmi
done. Nicer indeed. Here when using French:
Note: Title is in English above as we have no French string yet.