[#19912] - Don't have a metadataManager class property to avoid circular dependency problem when instantiating multiple applications
- Fixed in Code Base
- 15 Mar 2018
- Medium
- Build: staging
- # 19912
- Diff
- mbabker:metadatamanager-change
User tests: Successful: Unsuccessful:
Pull Request for Issue #19902
Summary of Changes
Removes CMSApplication::$metadataManager due to the circular dependency problem that exists with instantiating multiple applications with this property, move instantiation into the application's checkSession method.
Testing Instructions
Anywhere in an extension, add a new JSite; line.
Pre-patch, you should get the Nesting level too deep - recursive dependency? in joomla/libraries/joomla/event/dispatcher.php on line 198 message. Post-patch, you shouldn't.
Documentation Changes Required
Technically breaking B/C by removing the property we added in this release since it's not private, otherwise no.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
Tested and works fine for me with this patch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19912.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-15 17:00:22 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on eb53304
To test I used the modification from #19902 (comment)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19912.