[#19905] - Fix asset for image button defaulting to global ACL permissions instead of current extension when NULL asset is passed
- Closed
- 24 Mar 2022
- Medium
- Build: staging
- # 19905
- Diff
- ggppdk:patch-58
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
Please check out here
https://github.com/joomla/joomla-cms/blob/staging/plugins/editors/tinymce/tinymce.php#L138
and you will see that default value for $asset is null
If you try to create an HTML editor area, using
$editor = JFactory::getEditor('somename');
echo $editor->display( ... $_asset = null, ...);for a user that has soft DENY (= 'not-set / inherit') for 'Create' in global permission but the user has 'Create' for an extension
then the 'image' editor XTD button will not show
that is because since J3.7.0 the check for falling back to component asset was made strict
a8bb66b#diff-7d40cca371daf67980431c91be993f26L43
a8bb66b#diff-7d40cca371daf67980431c91be993f26R51
Testing Instructions
Try to create an editor area for a user that only has submit 'Create' for a component and no other ACL privileges and also the user has soft DENY for create ('not-set / inherit') in Global permissions for create
Expected result
The image XTD button is shown
because user can open new record form
Actual result
The image XTD button is not shown
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
Removed: ? |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-24 14:59:31 |
| Closed_By | ⇒ | laoneo |
If this pr is still valid for Joomla 3.10, can you update your testing instructions, as they are hard to understand for an average user? In the meantime I'm closing it, when ready, please reopen it again. Thanks for your contribution and help making Joomla better.