Shouldnt the check also be checking to ensure that these are admin menu items

This works :) The language keys also are used in the form (title).

I have tested this item 🔴 unsuccessfully on 3f0d5f0

The patch works very well on menuitems. But when editing an item, the language key is not translated.

The patch works very well on menuitems. But when editing an item, the language key is not translated.

I guess it is voluntary in order to propose this custom admin menu what ever the language used in back-end.
@izharaazmi Is'nt it?

Please also see existing PR #19802

Shouldnt the check also be checking to ensure that these are admin menu items

The patch does it by checking clientId.

+		// Load mod_menu.ini file when client is administrator
+		if ($clientId == 1)
etc.

@infograf768 Yes, during editing if we translate it in the title field, it will no longer remain translatable.

@chmst Please change your review 😃 as this is intended behaviour.

I do not know this problem, maybe I'm wrong, but IMO loading the translation or translation of the title in the model in general (PR #19802) is strange. May be it should be transferred for ex. to the controller (this PR) and to the view (PR #19802).

@csthomas
This would mean, for this PR, adding a new method in the controller. Looks like overkill.

I have tested this item ✅ successfully on 3f0d5f0

Items are translated as described. Thank you @infograf768

When editing, should Parent Item and Ordering dropdowns show the translated text?

@Quy
That is a very good idea. Easy enough by adding the same code in edit.php
I think though that it should be a different PR. I am preparing it now.

In the mean while, can you test this one so that we RTC it?

Also, if you folks like, I can add in that new PR some code to display the translation of the menu Title. Needs one lang string to add.

We would get:

and the translations for Parent Item and Ordering

What do you think?

Translate parent item and ordering is great. However we need to indicate that the translated title is not dynamic and will be updated on save. Or are we really going to make it on ajax?

@izharaazmi
While working on this, I found out that the presets do NOT fill the Menu Item Type.
It forces therefore, for any modification, to use the Select button and find again the correct menu item in the modal to allow saving.
Can you look at that issue?

ADDED: see #19904

If the Title is modified and the item is saved, the new value will be updated as you correctly state. Not sure I understand your concern.

But I think we should have this debate in the new PR to come.
In the mean while, le'ts get a RTC on this one as it is specific to the manager please. ;)

Please also test #19916 concerning editing one of these menu items created by presets.

I have tested this item ✅ successfully on 3f0d5f0

RTC