User tests: Successful: Unsuccessful:
Pull Request for Issue #19827.
In this PR #18195 this bug #15134 was fixed that is hiding the proceed button from the items with Trashed status. However, the fix affected all the statuses from the admin menus.
The old condition:
<?php if ((strlen($menuType) && $menuType != '*' && $clientId == 0) || ($published > 0 && $clientId == 1)): ?>
$published
can be:
""
when no status
is selected0
when Unpublished
status is selected1
when Published
status is selected-2
when Trashed
status is selectedNew condition, taking care of the items with Trashed state selected
<?php if (strlen($menuType) && $menuType != '*' && $published != -2): ?>
Hide proceed button when selected items state is Trashed, show it otherwise.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_menus |
I have tested this item
@izharaazmi
Is this PR OK for you?
Labels |
Added:
?
|
I fixed this bug, but as it was related to the other bug for the items with Trashed status, I observed that:
I believe that with the current implementation, there is no way of doing this in the backend, but I could write a JS script that at least hides the button in this case.
PS: Removed extra parenthesis :D
IMHO, nothing should stop us to batch process the trashed items. However, I haven't looked closely so I can't tell for sure.
If this is really the special case with trashed items, then we should have:
if (strlen($menuType) && $menuType != '*' && strlen($published) && $published != '*' && $published != -2)
@izharaazmi, in your solution the proceed button is displayed only in the case when the selected state is 'Published' or 'Unpublished' but it is not shown when selected 'All', which affects the published and unpublished items together with the trashed ones. Indeed I don't know why trashed items shouldn't be batched, I've just followed what the other bug(#15134) said.
I have tested this item
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-14 07:09:08 |
Closed_By | ⇒ | infograf768 |
I have tested this item✅ successfully on 0e2851d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19879.